Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-28 Thread Frederic Weisbecker
On Fri, Aug 28, 2015 at 10:32:59AM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > On Tue, Aug 25, 2015 at 10:29:04AM +0200, Ingo Molnar wrote: > > > > > > * Frederic Weisbecker wrote: > > > > > > > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > > > > 2) > >

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-28 Thread Ingo Molnar
* Frederic Weisbecker wrote: > On Tue, Aug 25, 2015 at 10:29:04AM +0200, Ingo Molnar wrote: > > > > * Frederic Weisbecker wrote: > > > > > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > > > 2) > > > > > > > > What happens if the boot CPU is offlined? (under > > > > CONFIG_

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-25 Thread Frederic Weisbecker
On Tue, Aug 25, 2015 at 10:29:04AM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > > 2) > > > > > > What happens if the boot CPU is offlined? (under > > > CONFIG_BOOTPARAM_HOTPLUG_CPU0=y) > > > > > > I don't see

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-25 Thread Ingo Molnar
* Frederic Weisbecker wrote: > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > 2) > > > > What happens if the boot CPU is offlined? (under > > CONFIG_BOOTPARAM_HOTPLUG_CPU0=y) > > > > I don't see CPU hotplug callbacks fixing up the housekeeping_mask if the > > boot CPU > >

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Paul E. McKenney
On Mon, Aug 24, 2015 at 04:04:37PM +0200, Frederic Weisbecker wrote: > On Mon, Aug 24, 2015 at 06:50:18AM -0700, Paul E. McKenney wrote: > > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > > > > > * Paul E. McKenney wrote: > > > > > > > > here it's fully set - triggering the bug

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Frederic Weisbecker
On Mon, Aug 24, 2015 at 06:50:18AM -0700, Paul E. McKenney wrote: > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > > > * Paul E. McKenney wrote: > > > > > > here it's fully set - triggering the bug I'm worried about. So what am > > > > I > > > > missing, what prevents CONFIG_

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Mike Galbraith
On Mon, 2015-08-24 at 15:36 +0200, Frederic Weisbecker wrote: > On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > 2) > > > > What happens if the boot CPU is offlined? (under > > CONFIG_BOOTPARAM_HOTPLUG_CPU0=y) > > > > I don't see CPU hotplug callbacks fixing up the housekeeping_m

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Paul E. McKenney
On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > > here it's fully set - triggering the bug I'm worried about. So what am I > > > missing, what prevents CONFIG_NO_HZ_FULL_ALL from crashing? > > > > The boot CPU is excluded from tick_nohz_full_mas

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Frederic Weisbecker
On Mon, Aug 24, 2015 at 08:44:12AM +0200, Ingo Molnar wrote: > 2) > > What happens if the boot CPU is offlined? (under > CONFIG_BOOTPARAM_HOTPLUG_CPU0=y) > > I don't see CPU hotplug callbacks fixing up the housekeeping_mask if the boot > CPU > is offlined. We have tick_nohz_cpu_down_callback(

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Ingo Molnar
* Mike Galbraith wrote: > On Mon, 2015-08-24 at 09:41 +0200, Ingo Molnar wrote: > > * Mike Galbraith wrote: > > > > > On Mon, 2015-08-24 at 08:44 +0200, Ingo Molnar wrote: > > > > > > > the 'housekeeping CPU' is essentially the boot CPU. Yet we dedicate a > > > > full mask to > > > > it (ho

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Mike Galbraith
On Mon, 2015-08-24 at 09:41 +0200, Ingo Molnar wrote: > * Mike Galbraith wrote: > > > On Mon, 2015-08-24 at 08:44 +0200, Ingo Molnar wrote: > > > > > the 'housekeeping CPU' is essentially the boot CPU. Yet we dedicate a > > > full mask to > > > it (housekeeping_mask - a variable mask to begin

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Ingo Molnar
* Mike Galbraith wrote: > On Mon, 2015-08-24 at 08:44 +0200, Ingo Molnar wrote: > > > the 'housekeeping CPU' is essentially the boot CPU. Yet we dedicate a full > > mask to > > it (housekeeping_mask - a variable mask to begin with) and recover the > > housekeeping CPU via: > > > > + r

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-24 Thread Mike Galbraith
On Mon, 2015-08-24 at 08:44 +0200, Ingo Molnar wrote: > the 'housekeeping CPU' is essentially the boot CPU. Yet we dedicate a full > mask to > it (housekeeping_mask - a variable mask to begin with) and recover the > housekeeping CPU via: > > + return cpumask_any_and(housekeeping_mask, cp

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-23 Thread Ingo Molnar
* Paul E. McKenney wrote: > > here it's fully set - triggering the bug I'm worried about. So what am I > > missing, what prevents CONFIG_NO_HZ_FULL_ALL from crashing? > > The boot CPU is excluded from tick_nohz_full_mask in tick_nohz_init(), which > is > called from tick_init() which is call

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-23 Thread Frederic Weisbecker
On Sun, Aug 23, 2015 at 07:40:32AM +0200, Ingo Molnar wrote: > So I almost applied this yesterday, but had the following question: what > ensures > that housekeeping_mask isn't empty? If it's empty then housekeeping_any_cpu() > returns cpumask_any_and() of an empty cpumask - which returns an out

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-23 Thread Frederic Weisbecker
On Sun, Aug 23, 2015 at 09:01:01AM -0700, Paul E. McKenney wrote: > The boot CPU is excluded from tick_nohz_full_mask in tick_nohz_init(), > which is called from tick_init() which is called from start_kernel() > shortly after rcu_init(): > > cpu = smp_processor_id(); > > if (cpumask_t

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-23 Thread Paul E. McKenney
On Sun, Aug 23, 2015 at 07:40:32AM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > From: Vatika Harlalka > > > > The problem addressed in this patch is about affining unpinned timers. > > Adaptive or Full Dynticks CPUs are currently disturbed by unnecessary > > jitter due to f

Re: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-22 Thread Ingo Molnar
* Frederic Weisbecker wrote: > From: Vatika Harlalka > > The problem addressed in this patch is about affining unpinned timers. > Adaptive or Full Dynticks CPUs are currently disturbed by unnecessary > jitter due to firing of such timers on them. > > This patch will affine timers to online CP

Re: Ping: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-22 Thread Christoph Lameter
On Sat, 22 Aug 2015, Frederic Weisbecker wrote: > Ping! Exellent!!! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://ww

Ping: [PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-22 Thread Frederic Weisbecker
Ping! On Fri, Aug 14, 2015 at 03:46:14AM +0200, Frederic Weisbecker wrote: > From: Vatika Harlalka > > The problem addressed in this patch is about affining unpinned timers. > Adaptive or Full Dynticks CPUs are currently disturbed by unnecessary > jitter due to firing of such timers on them. >

[PATCH RESEND] sched/nohz: Affine unpinned timers to housekeepers

2015-08-13 Thread Frederic Weisbecker
From: Vatika Harlalka The problem addressed in this patch is about affining unpinned timers. Adaptive or Full Dynticks CPUs are currently disturbed by unnecessary jitter due to firing of such timers on them. This patch will affine timers to online CPUs which are not full dynticks in NOHZ_FULL co