Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-12-05 Thread Alan Cox
On Wed, 05 Dec 2012 17:15:40 +0100 Sebastian Andrzej Siewior wrote: > On 12/03/2012 06:41 PM, Peter Hurley wrote: > > The lock logic for tty_set_ldisc() is wrong. Despite existing code in > > tty_set_ldisc() and tty_ldisc_hangup(), the ldisc_mutex does **not** > > (and should not) play a role in

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-12-05 Thread Sebastian Andrzej Siewior
On 12/03/2012 06:41 PM, Peter Hurley wrote: The lock logic for tty_set_ldisc() is wrong. Despite existing code in tty_set_ldisc() and tty_ldisc_hangup(), the ldisc_mutex does **not** (and should not) play a role in acquiring or releasing ldisc references. The only thing that needs to happen here

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-12-03 Thread Peter Hurley
On Tue, 2012-11-27 at 19:01 +0100, Sebastian Andrzej Siewior wrote: > Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock > in one of my dummy_hcd + g_nokia test cases. The first run one was usually > okay, the second often resulted in a splat by lockdep and the third was > usual

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-30 Thread Sebastian Andrzej Siewior
On Fri, Nov 30, 2012 at 09:21:43AM -0800, Greg Kroah-Hartman wrote: > > Ping. Can you feed this to your tty tree? :) > > It's really late in the release cycle, I would like to have this get > more testing in linux-next before I send it to Linus, so I was going to > wait until after 3.8-rc1 is out

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-30 Thread Greg Kroah-Hartman
On Fri, Nov 30, 2012 at 06:09:38PM +0100, Sebastian Andrzej Siewior wrote: > On Tue, Nov 27, 2012 at 07:01:08PM +0100, Sebastian Andrzej Siewior wrote: > > Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock > > in one of my dummy_hcd + g_nokia test cases. The first run one was u

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-30 Thread Sebastian Andrzej Siewior
On Tue, Nov 27, 2012 at 07:01:08PM +0100, Sebastian Andrzej Siewior wrote: > Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock > in one of my dummy_hcd + g_nokia test cases. The first run one was usually > okay, the second often resulted in a splat by lockdep and the third was

[PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-27 Thread Sebastian Andrzej Siewior
Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock in one of my dummy_hcd + g_nokia test cases. The first run one was usually okay, the second often resulted in a splat by lockdep and the third was usually a dead lock. Lockdep complained about tty->hangup_work and tty->legacy_mu