Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-08-22 Thread Brian Norris
On Thu, May 30, 2013 at 10:22:12AM +0800, Libo Chen wrote: > > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > So I use devm_kazlloc instead of kazlloc to avoid it. > > * Changelog: >convert to devm_kzalloc > > Signed-off-by: Libo chen >

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-08-22 Thread Brian Norris
On Thu, May 30, 2013 at 10:22:12AM +0800, Libo Chen wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. * Changelog: convert to devm_kzalloc Signed-off-by: Libo chen libo.c...@huawei.com

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-31 Thread Rafał Miłecki
2013/5/30 Libo Chen : > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > So I use devm_kazlloc instead of kazlloc to avoid it. I think you should use mtd: bcm47xxsflash: prefix for both patches, but Artem or David may want to comment on that. Nice trick

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-31 Thread Rafał Miłecki
2013/5/30 Libo Chen clbchenlibo.c...@huawei.com: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. I think you should use mtd: bcm47xxsflash: prefix for both patches, but Artem or David may want to

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-30 Thread Andy Shevchenko
On Thu, May 30, 2013 at 5:22 AM, Libo Chen wrote: > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > So I use devm_kazlloc instead of kazlloc to avoid it. You may amend commit message, but technically you have my Reviewed-by: Andy Shevchenko > diff

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-30 Thread Andy Shevchenko
On Thu, May 30, 2013 at 5:22 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. You may amend commit message, but technically you have my Reviewed-by: Andy

[PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-29 Thread Libo Chen
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. * Changelog: convert to devm_kzalloc Signed-off-by: Libo chen Suggested-by: Andy Shevchenko --- drivers/mtd/devices/bcm47xxsflash.c | 16

[PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-29 Thread Libo Chen
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. * Changelog: convert to devm_kzalloc Signed-off-by: Libo chen libo.c...@huawei.com Suggested-by: Andy Shevchenko andy.shevche...@gmail.com ---