Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-29 Thread Kay Sievers
On Thu, Nov 29, 2012 at 3:18 PM, Michael Kerrisk (man-pages) wrote: > So, just to be clear: you better not apply your patch; it might break > something ;-). Sounds good to me. :) Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-29 Thread Michael Kerrisk (man-pages)
On Thu, Nov 29, 2012 at 3:08 PM, Kay Sievers wrote: > On Thu, Nov 29, 2012 at 2:37 PM, Michael Kerrisk (man-pages) > wrote: >> On Thu, Nov 29, 2012 at 2:28 PM, Kay Sievers wrote: >>> On Thu, Nov 29, 2012 at 2:18 PM, Michael Kerrisk (man-pages) >>> wrote: On Wed, Nov 28, 2012 at 6:51 PM, Ka

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-29 Thread Kay Sievers
On Thu, Nov 29, 2012 at 2:37 PM, Michael Kerrisk (man-pages) wrote: > On Thu, Nov 29, 2012 at 2:28 PM, Kay Sievers wrote: >> On Thu, Nov 29, 2012 at 2:18 PM, Michael Kerrisk (man-pages) >> wrote: >>> On Wed, Nov 28, 2012 at 6:51 PM, Kay Sievers wrote: >> Before: syslog(SYSLOG_ACTION

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-29 Thread Michael Kerrisk (man-pages)
On Thu, Nov 29, 2012 at 2:28 PM, Kay Sievers wrote: > On Thu, Nov 29, 2012 at 2:18 PM, Michael Kerrisk (man-pages) > wrote: >> On Wed, Nov 28, 2012 at 6:51 PM, Kay Sievers wrote: > >>> Before: >>> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0) = 286965 >>> syslog(SYSLOG_ACTION_READ_CLEAR, "<12>"...

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-29 Thread Kay Sievers
On Thu, Nov 29, 2012 at 2:18 PM, Michael Kerrisk (man-pages) wrote: > On Wed, Nov 28, 2012 at 6:51 PM, Kay Sievers wrote: >> Before: >> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0) = 286965 >> syslog(SYSLOG_ACTION_READ_CLEAR, "<12>"..., 100) = 24000 >> syslog(SYSLOG_ACTION_SIZE_UNREAD, 0, 0

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-29 Thread Michael Kerrisk (man-pages)
On Wed, Nov 28, 2012 at 6:51 PM, Kay Sievers wrote: > On Wed, 2012-11-28 at 17:49 +0100, Kay Sievers wrote: >> On Wed, Nov 28, 2012 at 5:37 PM, Linus Torvalds >> wrote: >> > On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers wrote: >> >> On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk >> >> wrote:

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-28 Thread Kay Sievers
On Wed, 2012-11-28 at 17:49 +0100, Kay Sievers wrote: > On Wed, Nov 28, 2012 at 5:37 PM, Linus Torvalds > wrote: > > On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers wrote: > >> On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk > >> wrote: > >> > >>> On a 2.6.31 system, immediately after SYSLOG_ACTI

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-28 Thread Kay Sievers
On Wed, Nov 28, 2012 at 5:37 PM, Linus Torvalds wrote: > On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers wrote: >> On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk >> wrote: >> >>> On a 2.6.31 system, immediately after SYSLOG_ACTION_READ_CLEAR, a >>> SYSLOG_ACTION_SIZE_UNREAD returns 0. >> >> Hmm,

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-28 Thread Linus Torvalds
On Wed, Nov 28, 2012 at 8:22 AM, Kay Sievers wrote: > On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk > wrote: > >> On a 2.6.31 system, immediately after SYSLOG_ACTION_READ_CLEAR, a >> SYSLOG_ACTION_SIZE_UNREAD returns 0. > > Hmm, sounds like the right thing to do. Right. And that's the *OLD*

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-28 Thread Kay Sievers
On Wed, Nov 28, 2012 at 2:33 PM, Michael Kerrisk wrote: > On Thu, May 3, 2012 at 2:29 AM, Kay Sievers wrote: >> From: Kay Sievers > [...] >> case SYSLOG_ACTION_SIZE_UNREAD: >> - error = log_end - log_start; >> + raw_spin_lock_irq(&logbuf_lock); >> +

Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

2012-11-28 Thread Michael Kerrisk
Hi Kay, On Thu, May 3, 2012 at 2:29 AM, Kay Sievers wrote: > From: Kay Sievers [...] > case SYSLOG_ACTION_SIZE_UNREAD: > - error = log_end - log_start; > + raw_spin_lock_irq(&logbuf_lock); > + if (syslog_seq < log_first_seq) { > +