Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-23 Thread Jacek Anaszewski
Hi Milo, On 11/23/2015 12:40 AM, Kim, Milo wrote: Hi Jacek, On 11/20/2015 6:22 PM, Jacek Anaszewski wrote: On 11/10/2015 08:38 AM, Kim, Milo wrote: [...] +cat /sys/class/leds//pattern_levels +low brightness: 0, high brightness: 255 + +What:/sys/class/le

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-22 Thread Kim, Milo
Hi Jacek, On 11/20/2015 6:22 PM, Jacek Anaszewski wrote: On 11/10/2015 08:38 AM, Kim, Milo wrote: [...] +cat /sys/class/leds//pattern_levels +low brightness: 0, high brightness: 255 + +What:/sys/class/leds//run_pattern +Date:Oct 2015 +KernelVersio

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-20 Thread Jacek Anaszewski
On 11/10/2015 08:38 AM, Kim, Milo wrote: [...] +cat /sys/class/leds//pattern_levels +low brightness: 0, high brightness: 255 + +What:/sys/class/leds//run_pattern +Date:Oct 2015 +KernelVersion:4.3 +Contact:Milo Kim +Description:write onl

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-12 Thread Jacek Anaszewski
Hi Milo, On 11/11/2015 03:16 AM, Kim, Milo wrote: Hi Jacek, On 11/10/2015 10:44 PM, Jacek Anaszewski wrote: +static ssize_t lm3633_led_store_pattern_levels(struct device *dev, >>>+ struct device_attribute *attr, >>>+ const char *buf, size_t l

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-10 Thread Kim, Milo
Hi Jacek, On 11/10/2015 10:44 PM, Jacek Anaszewski wrote: +static ssize_t lm3633_led_store_pattern_levels(struct device *dev, >>>+ struct device_attribute *attr, >>>+ const char *buf, size_t len) >>>+{ >>>+struct ti_lmu_led *lmu_led = to_ti

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-10 Thread Jacek Anaszewski
On 11/10/2015 08:38 AM, Kim, Milo wrote: Hi Jacek, On 11/4/2015 1:15 AM, Jacek Anaszewski wrote: Hi Milo, Thanks for the patch. Please find my comments in the code. diff --git a/Documentation/ABI/testing/sysfs-class-led-lm3633 b/Documentation/ABI/testing/sysfs-class-led-lm3633 new file mode

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-09 Thread Kim, Milo
Hi Jacek, On 11/4/2015 1:15 AM, Jacek Anaszewski wrote: Hi Milo, Thanks for the patch. Please find my comments in the code. diff --git a/Documentation/ABI/testing/sysfs-class-led-lm3633 b/Documentation/ABI/testing/sysfs-class-led-lm3633 new file mode 100644 index 000..c1d8759 --- /dev/nu

Re: [PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-03 Thread Jacek Anaszewski
Hi Milo, Thanks for the patch. Please find my comments in the code. On 11/02/2015 06:24 AM, Milo Kim wrote: LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated through the sysfs. ABI documentation is also added. Device creation from device tree ---

[PATCH RESEND 15/16] leds: add LM3633 driver

2015-11-01 Thread Milo Kim
LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated through the sysfs. ABI documentation is also added. Device creation from device tree LED channel name, LED string usage and max current settings are configured inside