Re: [PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

Hi Enric, Thanks for the review. On 30/11/2016 16:48, Enric Balletbo Serra wrote: Hi Thierry, I reviewed your patches and looks good to me, I only found a few style things that is up to maintainer decide if are needed or not, most of them are feedback I received on other subsystems. Ah, and

Re: [PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

Hi Enric, Thanks for the review. On 30/11/2016 16:48, Enric Balletbo Serra wrote: Hi Thierry, I reviewed your patches and looks good to me, I only found a few style things that is up to maintainer decide if are needed or not, most of them are feedback I received on other subsystems. Ah, and

Re: [PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

Hi Thierry, I reviewed your patches and looks good to me, I only found a few style things that is up to maintainer decide if are needed or not, most of them are feedback I received on other subsystems. Ah, and I've a question about runtime detection of the EC (see below), but guess the answer is

Re: [PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

Hi Thierry, I reviewed your patches and looks good to me, I only found a few style things that is up to maintainer decide if are needed or not, most of them are feedback I received on other subsystems. Ah, and I've a question about runtime detection of the EC (see below), but guess the answer is

[PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

From: Shawn Nematbakhsh This adds support for the ChromeOS LPC Microchip Embedded Controller (mec1322) variant. mec1322 accesses I/O region [800h, 9ffh] through embedded memory interface (EMI) rather than LPC. Signed-off-by: Shawn Nematbakhsh

[PATCH RESEND 2/2] platform/chrome: cros_ec_lpc: Add support for mec1322 EC

From: Shawn Nematbakhsh This adds support for the ChromeOS LPC Microchip Embedded Controller (mec1322) variant. mec1322 accesses I/O region [800h, 9ffh] through embedded memory interface (EMI) rather than LPC. Signed-off-by: Shawn Nematbakhsh Signed-off-by: Gwendal Grignou Signed-off-by: