Re: [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio

2020-08-17 Thread Baolin Wang
On Mon, Aug 17, 2020 at 02:24:40PM +0200, Christoph Hellwig wrote: > On Mon, Aug 17, 2020 at 08:10:02PM +0800, Baolin Wang wrote: > > On Mon, Aug 17, 2020 at 08:26:34AM +0200, Christoph Hellwig wrote: > > > On Mon, Aug 17, 2020 at 12:09:17PM +0800, Baolin Wang wrote: > > > > There are lots of dupli

Re: [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio

2020-08-17 Thread Christoph Hellwig
On Mon, Aug 17, 2020 at 08:10:02PM +0800, Baolin Wang wrote: > On Mon, Aug 17, 2020 at 08:26:34AM +0200, Christoph Hellwig wrote: > > On Mon, Aug 17, 2020 at 12:09:17PM +0800, Baolin Wang wrote: > > > There are lots of duplicated code when trying to merge a bio from > > > plug list and sw queue, we

Re: [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio

2020-08-17 Thread Baolin Wang
On Mon, Aug 17, 2020 at 08:26:34AM +0200, Christoph Hellwig wrote: > On Mon, Aug 17, 2020 at 12:09:17PM +0800, Baolin Wang wrote: > > There are lots of duplicated code when trying to merge a bio from > > plug list and sw queue, we can introduce a new helper to attempt > > to merge a bio, which can

Re: [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio

2020-08-17 Thread kernel test robot
Hi Baolin, I love your patch! Perhaps something to improve: [auto build test WARNING on block/for-next] [also build test WARNING on v5.9-rc1 next-20200817] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented i

Re: [PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio

2020-08-16 Thread Christoph Hellwig
On Mon, Aug 17, 2020 at 12:09:17PM +0800, Baolin Wang wrote: > There are lots of duplicated code when trying to merge a bio from > plug list and sw queue, we can introduce a new helper to attempt > to merge a bio, which can simplify the blk_mq_bio_list_merge() > and blk_attempt_plug_merge(). Looks

[PATCH RESEND 3/5] block: Add a new helper to attempt to merge a bio

2020-08-16 Thread Baolin Wang
There are lots of duplicated code when trying to merge a bio from plug list and sw queue, we can introduce a new helper to attempt to merge a bio, which can simplify the blk_mq_bio_list_merge() and blk_attempt_plug_merge(). Signed-off-by: Baolin Wang --- block/blk-merge.c| 47 +++