Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper

2020-08-17 Thread Baolin Wang
On Mon, Aug 17, 2020 at 02:26:08PM +0200, Christoph Hellwig wrote: > On Mon, Aug 17, 2020 at 08:14:08PM +0800, Baolin Wang wrote: > > On Mon, Aug 17, 2020 at 08:32:41AM +0200, Christoph Hellwig wrote: > > > On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote: > > > > The blk_mq_sched_bio_me

Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper

2020-08-17 Thread Christoph Hellwig
On Mon, Aug 17, 2020 at 08:14:08PM +0800, Baolin Wang wrote: > On Mon, Aug 17, 2020 at 08:32:41AM +0200, Christoph Hellwig wrote: > > On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote: > > > The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and > > > no other places w

Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper

2020-08-17 Thread Baolin Wang
On Mon, Aug 17, 2020 at 08:32:41AM +0200, Christoph Hellwig wrote: > On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote: > > The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and > > no other places will use __blk_mq_sched_bio_merge(). Thus we can combine > > these 2 s

Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper

2020-08-16 Thread Christoph Hellwig
On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote: > The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and > no other places will use __blk_mq_sched_bio_merge(). Thus we can combine > these 2 similar functions into one function. I think the idea was to avoid the func

[PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper

2020-08-16 Thread Baolin Wang
The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and no other places will use __blk_mq_sched_bio_merge(). Thus we can combine these 2 similar functions into one function. Signed-off-by: Baolin Wang --- block/blk-mq-sched.c | 5 - block/blk-mq-sched.h | 13 ++---