Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-31 Thread Thierry Reding
On Thu, Oct 30, 2014 at 10:10:06AM -0700, Andrew Bresticker wrote: > On Thu, Oct 30, 2014 at 6:45 AM, Thierry Reding > wrote: > > On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: > >> >> diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c > >> >>

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-31 Thread Thierry Reding
On Thu, Oct 30, 2014 at 10:10:06AM -0700, Andrew Bresticker wrote: On Thu, Oct 30, 2014 at 6:45 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Andrew Bresticker
On Thu, Oct 30, 2014 at 6:45 AM, Thierry Reding wrote: > On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: >> >> diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c >> >> b/drivers/pinctrl/pinctrl-tegra-xusb.c > [...] >> >> + >> >> + for (i = 0; i < TEGRA_XUSB_USB3_PHYS; i++)

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: > >> diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c > >> b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] > >> + > >> + for (i = 0; i < TEGRA_XUSB_USB3_PHYS; i++) { > >> + if (phy ==

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] + + for (i = 0; i TEGRA_XUSB_USB3_PHYS; i++) { + if (phy == padctl-phys[TEGRA_XUSB_PADCTL_USB3_P0 + i]) +

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Andrew Bresticker
On Thu, Oct 30, 2014 at 6:45 AM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] + + for (i = 0; i TEGRA_XUSB_USB3_PHYS;

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-29 Thread Andrew Bresticker
>> diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c >> b/drivers/pinctrl/pinctrl-tegra-xusb.c > [...] >> struct tegra_xusb_padctl_function { >> const char *name; >> const char * const *groups; >> @@ -72,6 +222,16 @@ struct tegra_xusb_padctl_soc { >> >> const struct

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:51PM -0700, Andrew Bresticker wrote: [...] > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index c6a66de..0f4cdef 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -163,6 +163,7 @@ config PINCTRL_TEGRA_XUSB > select

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:51PM -0700, Andrew Bresticker wrote: [...] diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index c6a66de..0f4cdef 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -163,6 +163,7 @@ config PINCTRL_TEGRA_XUSB select

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-29 Thread Andrew Bresticker
diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] struct tegra_xusb_padctl_function { const char *name; const char * const *groups; @@ -72,6 +222,16 @@ struct tegra_xusb_padctl_soc { const struct tegra_xusb_padctl_lane

[PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-28 Thread Andrew Bresticker
In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages intended for the PHY driver, so request and listen

[PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-28 Thread Andrew Bresticker
In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages intended for the PHY driver, so request and listen