Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-09-06 Thread Lina Iyer
On Tue, Sep 04 2018 at 16:00 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2018-09-04 14:09:34) On Mon, Aug 27 2018 at 14:01 -0600, Stephen Boyd wrote: > >Can't we just configure a different chained IRQ handler with >irq_set_chained_handler_and_data() for each of the GPIO IRQs that are >handled

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-09-04 Thread Stephen Boyd
Quoting Lina Iyer (2018-09-04 14:09:34) > On Mon, Aug 27 2018 at 14:01 -0600, Stephen Boyd wrote: > > > >Can't we just configure a different chained IRQ handler with > >irq_set_chained_handler_and_data() for each of the GPIO IRQs that are > >handled by PDC to be the interrupts provide by the PDC ir

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-09-04 Thread Lina Iyer
On Mon, Aug 27 2018 at 14:01 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2018-08-24 10:14:32) On Fri, Aug 24 2018 at 02:22 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2018-08-17 12:10:23) >> During suspend the system may power down some of the system rails. As a >> result, the TLMM hw block

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-27 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-24 10:14:32) > On Fri, Aug 24 2018 at 02:22 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2018-08-17 12:10:23) > >> During suspend the system may power down some of the system rails. As a > >> result, the TLMM hw block may not be operational anymore and wakeup > >> cap

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-24 Thread Lina Iyer
On Fri, Aug 24 2018 at 02:22 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2018-08-17 12:10:23) During suspend the system may power down some of the system rails. As a result, the TLMM hw block may not be operational anymore and wakeup capable GPIOs will not be detected. The PDC however will be

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-24 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-17 12:10:23) > During suspend the system may power down some of the system rails. As a > result, the TLMM hw block may not be operational anymore and wakeup > capable GPIOs will not be detected. The PDC however will be operational > and the GPIOs that are routed to the PD

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-21 Thread Marc Zyngier
On Mon, 20 Aug 2018 09:49:59 -0600 Lina Iyer wrote: > On Mon, Aug 20 2018 at 09:34 -0600, Marc Zyngier wrote: > >On 20/08/18 16:26, Lina Iyer wrote: > >> On Sat, Aug 18 2018 at 07:13 -0600, Marc Zyngier wrote: > >>> Hi Lina, > >>> > >>> On Fri, 17 Aug 2018 20:10:23 +0100, > >>> Lina Iyer wro

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-20 Thread Lina Iyer
On Mon, Aug 20 2018 at 09:34 -0600, Marc Zyngier wrote: On 20/08/18 16:26, Lina Iyer wrote: On Sat, Aug 18 2018 at 07:13 -0600, Marc Zyngier wrote: Hi Lina, On Fri, 17 Aug 2018 20:10:23 +0100, Lina Iyer wrote: [...] @@ -920,6 +928,8 @@ static int msm_gpio_pdc_pin_request(struct irq_data *

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-20 Thread Marc Zyngier
On 20/08/18 16:26, Lina Iyer wrote: > On Sat, Aug 18 2018 at 07:13 -0600, Marc Zyngier wrote: >> Hi Lina, >> >> On Fri, 17 Aug 2018 20:10:23 +0100, >> Lina Iyer wrote: [...] >>> @@ -920,6 +928,8 @@ static int msm_gpio_pdc_pin_request(struct irq_data *d) >>> } >>> >>> irq_set_handler_data

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-20 Thread Lina Iyer
On Sat, Aug 18 2018 at 07:13 -0600, Marc Zyngier wrote: Hi Lina, On Fri, 17 Aug 2018 20:10:23 +0100, Lina Iyer wrote: During suspend the system may power down some of the system rails. As a result, the TLMM hw block may not be operational anymore and wakeup capable GPIOs will not be detected.

Re: [PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-18 Thread Marc Zyngier
Hi Lina, On Fri, 17 Aug 2018 20:10:23 +0100, Lina Iyer wrote: > > During suspend the system may power down some of the system rails. As a > result, the TLMM hw block may not be operational anymore and wakeup > capable GPIOs will not be detected. The PDC however will be operational > and the GPIO

[PATCH RESEND v1 2/5] drivers: pinctrl: msm: enable PDC interrupt only during suspend

2018-08-17 Thread Lina Iyer
During suspend the system may power down some of the system rails. As a result, the TLMM hw block may not be operational anymore and wakeup capable GPIOs will not be detected. The PDC however will be operational and the GPIOs that are routed to the PDC as IRQs can wake the system up. To avoid bein