Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-08-10 Thread Bjorn Andersson
On Wed, Aug 6, 2014 at 8:02 AM, Ivan T. Ivanov wrote: > On Fri, 2014-07-25 at 18:15 +0300, Ivan T. Ivanov wrote: >> On Thu, 2014-07-24 at 17:23 -0700, Stephen Boyd wrote: >> > On 07/24/14 08:40, Linus Walleij wrote: >> > > On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd >> > > wrote: >> > > >> > >

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-08-06 Thread Ivan T. Ivanov
On Fri, 2014-07-25 at 18:15 +0300, Ivan T. Ivanov wrote: > On Thu, 2014-07-24 at 17:23 -0700, Stephen Boyd wrote: > > On 07/24/14 08:40, Linus Walleij wrote: > > > On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd > > > wrote: > > > > > >>> Please add these constants to the table of valid power-sourc

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-25 Thread Ivan T. Ivanov
On Thu, 2014-07-24 at 17:23 -0700, Stephen Boyd wrote: > On 07/24/14 08:40, Linus Walleij wrote: > > On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd wrote: > > > >>> Please add these constants to the table of valid power-source values and > >>> use > >>> something like I did to translate them to re

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-25 Thread Linus Walleij
On Fri, Jul 25, 2014 at 2:23 AM, Stephen Boyd wrote: > On 07/24/14 08:40, Linus Walleij wrote: >> On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd wrote: >> Please add these constants to the table of valid power-source values and use something like I did to translate them to register

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-24 Thread Stephen Boyd
On 07/24/14 08:40, Linus Walleij wrote: > On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd wrote: > >>> Please add these constants to the table of valid power-source values and use >>> something like I did to translate them to register values - it makes the DT >>> much more readable. >> The DT could

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-24 Thread Linus Walleij
On Thu, Jul 24, 2014 at 1:47 AM, Stephen Boyd wrote: >> Please add these constants to the table of valid power-source values and use >> something like I did to translate them to register values - it makes the DT >> much more readable. > > The DT could be similarly readable if we had a bunch of #d

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-23 Thread Stephen Boyd
On 07/22/14 14:46, Bjorn Andersson wrote: > For pm8941 the valid power supply values are: > GPIO 1-14 >0: VPH >2: SMPS3 >3: LDO6 > > GPIO 15-18 > 2: SMPS3 > 3: LDO6 > > GPIO 19-36 > 0: VPH > 1: VDD_TORCH > 2: SPMS3 > 3: LDO6 > > MPP 1-8 > 0: VPH > 1: LDO1 > 2: SPMS

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-23 Thread Stephen Boyd
On 07/23/14 09:05, Ivan T. Ivanov wrote: > >> both on >>> pm8xxx and qpnp-pin there are two different HW blocks, one for GPIO and one >>> for >>> MPP. And if you look in your pinconf_set function you will see that they are >>> very different. > I bet that the hardware blocks are almost identical,

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-23 Thread Ivan T. Ivanov
Hi, I have accidentally pressed send in the earlier message. On Wed, 2014-07-23 at 15:47 +0300, Ivan T. Ivanov wrote: > On Tue, 2014-07-22 at 14:46 -0700, Bjorn Andersson wrote: > > On Thu, Jul 17, 2014 at 12:41 PM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > > > > Hi Ivan, >

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-23 Thread Ivan T. Ivanov
On Tue, 2014-07-22 at 14:46 -0700, Bjorn Andersson wrote: > On Thu, Jul 17, 2014 at 12:41 PM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Hi Ivan, > > Sorry for the slow response, I wanted to respin my pm8xxx-gpio driver to > figure > out some resonable answers to you. > > >

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-22 Thread Bjorn Andersson
On Thu, Jul 17, 2014 at 12:41 PM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > Hi Ivan, Sorry for the slow response, I wanted to respin my pm8xxx-gpio driver to figure out some resonable answers to you. > Available 'power-source' labels differ between chips. > Use just VIN0-VIN14 in the in

Re: [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-22 Thread Ivan T. Ivanov
On Thu, 2014-07-17 at 22:41 +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Available 'power-source' labels differ between chips. > Use just VIN0-VIN14 in the input source names. > > PM8018, PM8038, PM8058, PM8917, PM8921 pin controller hardware > support only one function 'gpio'. Curr

[PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions

2014-07-17 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Available 'power-source' labels differ between chips. Use just VIN0-VIN14 in the input source names. PM8018, PM8038, PM8058, PM8917, PM8921 pin controller hardware support only one function 'gpio'. Currently GPIO's will support only 'normal' mode. Rest of the modes will be