Re: [PATCH RESEND v2 2/4] mfd: intel_soc_pmic: I2C interface

2014-05-26 Thread Zhu, Lejun
On 5/24/2014 1:53 AM, Mark Brown wrote: > On Fri, May 23, 2014 at 08:40:27AM +0800, Zhu, Lejun wrote: > >> +static int pmic_i2c_lookup_gpio(struct device *dev, int acpi_index) >> +{ >> +struct gpio_desc *desc; >> +int gpio; >> + >> +desc = gpiod_get_index(dev, KBUILD_MODNAME,

Re: [PATCH RESEND v2 2/4] mfd: intel_soc_pmic: I2C interface

2014-05-26 Thread Zhu, Lejun
On 5/24/2014 1:53 AM, Mark Brown wrote: On Fri, May 23, 2014 at 08:40:27AM +0800, Zhu, Lejun wrote: +static int pmic_i2c_lookup_gpio(struct device *dev, int acpi_index) +{ +struct gpio_desc *desc; +int gpio; + +desc = gpiod_get_index(dev, KBUILD_MODNAME, acpi_index); +

Re: [PATCH RESEND v2 2/4] mfd: intel_soc_pmic: I2C interface

2014-05-23 Thread Mark Brown
On Fri, May 23, 2014 at 08:40:27AM +0800, Zhu, Lejun wrote: > +static int pmic_i2c_lookup_gpio(struct device *dev, int acpi_index) > +{ > + struct gpio_desc *desc; > + int gpio; > + > + desc = gpiod_get_index(dev, KBUILD_MODNAME, acpi_index); > + if (IS_ERR(desc)) > +

Re: [PATCH RESEND v2 2/4] mfd: intel_soc_pmic: I2C interface

2014-05-23 Thread Mark Brown
On Fri, May 23, 2014 at 08:40:27AM +0800, Zhu, Lejun wrote: +static int pmic_i2c_lookup_gpio(struct device *dev, int acpi_index) +{ + struct gpio_desc *desc; + int gpio; + + desc = gpiod_get_index(dev, KBUILD_MODNAME, acpi_index); + if (IS_ERR(desc)) + return

[PATCH RESEND v2 2/4] mfd: intel_soc_pmic: I2C interface

2014-05-22 Thread Zhu, Lejun
The Intel SoC PMIC devices are connected to the CPU via the I2C interface. This patch provides support of the related I2C operations. v2: - Use regmap instead of creating our own I2C read/write callbacks. Signed-off-by: Yang, Bin Signed-off-by: Zhu, Lejun --- drivers/mfd/intel_soc_pmic_i2c.c

[PATCH RESEND v2 2/4] mfd: intel_soc_pmic: I2C interface

2014-05-22 Thread Zhu, Lejun
The Intel SoC PMIC devices are connected to the CPU via the I2C interface. This patch provides support of the related I2C operations. v2: - Use regmap instead of creating our own I2C read/write callbacks. Signed-off-by: Yang, Bin bin.y...@intel.com Signed-off-by: Zhu, Lejun