2013/6/19, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>>>If above is correct, right implement to change get_block().
>> Now when we try to write in the fallocated region ( with keep size) in
>> the fat_write_begin when it is called first time it checks that the
>> mismatch is present between the mmu
Namjae Jeon writes:
>>If above is correct, right implement to change get_block().
> Now when we try to write in the fallocated region ( with keep size) in
> the fat_write_begin when it is called first time it checks that the
> mismatch is present between the mmu_private and mmu_actual , and hence
Hi, OGAWA.
We checked several cases with respect to your questions. But we cannot
find any issue.
Also, We compare the results with Ext4. It is same.
>cluster size == 512b
>1) create new file
>2) fallocate 100MB
>3) write(2) data for each 512b
>With this, write_begin() will be called for each 51
2013/5/2, OGAWA Hirofumi :
> Namjae Jeon writes:
>
AFAIK, preallocation != fallocate. ext*'s preallocation was there at
before fallocation to optimize block allocation for user data blocks.
>> yes, this is correct , preallocation!= fallocate, we just adopted only
>> the "release part" fr
Namjae Jeon writes:
>>> AFAIK, preallocation != fallocate. ext*'s preallocation was there at
>>> before fallocation to optimize block allocation for user data blocks.
> yes, this is correct , preallocation!= fallocate, we just adopted only
> the "release part" from that approach
> Sorry, Would yo
2013/5/2, OGAWA Hirofumi :
> OGAWA Hirofumi writes:
>
>> Namjae Jeon writes:
>>
Then, per-file discard fallocate space sounds like wrong. fallocate
space probably is inode attribute.
>>> Since, our preallocation will not be persistent after umount. So, we
>>> need to free up the space a
OGAWA Hirofumi writes:
> Namjae Jeon writes:
>
>>> Then, per-file discard fallocate space sounds like wrong. fallocate
>>> space probably is inode attribute.
>> Since, our preallocation will not be persistent after umount. So, we
>> need to free up the space at some point.
>> If we consider for
Namjae Jeon writes:
>> Then, per-file discard fallocate space sounds like wrong. fallocate
>> space probably is inode attribute.
> Since, our preallocation will not be persistent after umount. So, we
> need to free up the space at some point.
> If we consider for normal pre-allocation in ext4, in
2013/5/2, OGAWA Hirofumi :
> Namjae Jeon writes:
>
> Hm, why d_count == 1 check is needed? Feel strange and racy.
Since, fat_file_release() is called on every close for the file.
>>>
>>> What is wrong? IIRC, it is what you choose (i.e. for each last close for
>>> the file descriptor).
>>
Namjae Jeon writes:
Hm, why d_count == 1 check is needed? Feel strange and racy.
>>> Since, fat_file_release() is called on every close for the file.
>>
>> What is wrong? IIRC, it is what you choose (i.e. for each last close for
>> the file descriptor).
> Yes, this is what we had chosen afte
2013/5/1, OGAWA Hirofumi :
> Namjae Jeon writes:
>
>> Hi OGAWA.
>
> Hi,
>
>>> I couldn't review fully though.
>>>
+ if (mmu_private_ideal < MSDOS_I(inode)->mmu_private &&
+ filp->f_dentry->d_count == 1)
+ fat_truncate_blocks(inode, inode->i_size);
>>>
>>> Hm, why d_co
Namjae Jeon writes:
> Hi OGAWA.
Hi,
>> I couldn't review fully though.
>>
>>> + if (mmu_private_ideal < MSDOS_I(inode)->mmu_private &&
>>> + filp->f_dentry->d_count == 1)
>>> + fat_truncate_blocks(inode, inode->i_size);
>>
>> Hm, why d_count == 1 check is needed? Feel strange
2013/4/29, OGAWA Hirofumi :
> Namjae Jeon writes:
>
Hi OGAWA.
> I couldn't review fully though.
>
>> +if (mmu_private_ideal < MSDOS_I(inode)->mmu_private &&
>> +filp->f_dentry->d_count == 1)
>> +fat_truncate_blocks(inode, inode->i_size);
>
> Hm, why d_count == 1 check is ne
Namjae Jeon writes:
I couldn't review fully though.
> + if (mmu_private_ideal < MSDOS_I(inode)->mmu_private &&
> + filp->f_dentry->d_count == 1)
> + fat_truncate_blocks(inode, inode->i_size);
Hm, why d_count == 1 check is needed? Feel strange and racy.
> + /
From: Namjae Jeon
Implement preallocation via the fallocate syscall on VFAT partitions.
Change Log:
v5: change to avoid compilation warning:
fs/fat/inode.c: In function 'fat_zero_falloc_area':
>> fs/fat/inode.c:169:11: warning: comparison of distinct pointer
types lacks a cast [enabled by defa
15 matches
Mail list logo
