Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-14 Thread jianchao.wang
Hi Keith Thanks for your kindly response and directive. And 恭喜发财 大吉大利！！ On 02/14/2018 05:52 AM, Keith Busch wrote: > On Mon, Feb 12, 2018 at 09:05:13PM +0800, Jianchao Wang wrote: >> @@ -1315,9 +1315,6 @@ static int nvme_suspend_queue(struct nvme_queue *nvmeq) >> nvmeq->cq_vector = -1; >>

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-14 Thread jianchao.wang
Hi Keith Thanks for your kindly response and directive. And 恭喜发财 大吉大利！！ On 02/14/2018 05:52 AM, Keith Busch wrote: > On Mon, Feb 12, 2018 at 09:05:13PM +0800, Jianchao Wang wrote: >> @@ -1315,9 +1315,6 @@ static int nvme_suspend_queue(struct nvme_queue *nvmeq) >> nvmeq->cq_vector = -1; >>

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-13 Thread Keith Busch
On Mon, Feb 12, 2018 at 09:05:13PM +0800, Jianchao Wang wrote: > @@ -1315,9 +1315,6 @@ static int nvme_suspend_queue(struct nvme_queue *nvmeq) > nvmeq->cq_vector = -1; > spin_unlock_irq(>q_lock); > > - if (!nvmeq->qid && nvmeq->dev->ctrl.admin_q) > -

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-13 Thread Keith Busch
On Mon, Feb 12, 2018 at 09:05:13PM +0800, Jianchao Wang wrote: > @@ -1315,9 +1315,6 @@ static int nvme_suspend_queue(struct nvme_queue *nvmeq) > nvmeq->cq_vector = -1; > spin_unlock_irq(>q_lock); > > - if (!nvmeq->qid && nvmeq->dev->ctrl.admin_q) > -

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-12 Thread jianchao.wang
Hi Sagi Thanks for your kindly response. On 02/13/2018 02:37 AM, Sagi Grimberg wrote: > >> nvme cq irq is freed based on queue_count. When the sq/cq creation >> fails, irq will not be setup. free_irq will warn 'Try to free >> already-free irq'. >> >> To fix it, we only increase online_queues

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-12 Thread jianchao.wang
Hi Sagi Thanks for your kindly response. On 02/13/2018 02:37 AM, Sagi Grimberg wrote: > >> nvme cq irq is freed based on queue_count. When the sq/cq creation >> fails, irq will not be setup. free_irq will warn 'Try to free >> already-free irq'. >> >> To fix it, we only increase online_queues

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-12 Thread Sagi Grimberg
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, we only increase online_queues when adminq/sq/cq are created and associated irq is setup. Then suspend queues based on online_queues.

Re: [PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-12 Thread Sagi Grimberg
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, we only increase online_queues when adminq/sq/cq are created and associated irq is setup. Then suspend queues based on online_queues.

[PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-12 Thread Jianchao Wang
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, we only increase online_queues when adminq/sq/cq are created and associated irq is setup. Then suspend queues based on online_queues.

[PATCH RESENT] nvme-pci: suspend queues based on online_queues

2018-02-12 Thread Jianchao Wang
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, we only increase online_queues when adminq/sq/cq are created and associated irq is setup. Then suspend queues based on online_queues.