Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-11 Thread Rusty Russell
On Tuesday 11 December 2007 05:50:08 Sam Ravnborg wrote: > On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: > > This way gcc can warn for wrong format strings > > This loks good. Can I get i s-o-b then I will apply it. Even better, switch the code to the standard warn/warnx/err/errx.

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-11 Thread Rusty Russell
On Tuesday 11 December 2007 05:50:08 Sam Ravnborg wrote: On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Even better, switch the code to the standard warn/warnx/err/errx.

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-10 Thread Andi Kleen
On Mon, Dec 10, 2007 at 07:50:08PM +0100, Sam Ravnborg wrote: > On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: > > > > This way gcc can warn for wrong format strings > > This loks good. Can I get i s-o-b then I will apply it. Sorry must have been left out by mistake.

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-10 Thread Sam Ravnborg
On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: > > This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Sam > > --- > scripts/mod/modpost.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > Index:

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-10 Thread Sam Ravnborg
On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Sam --- scripts/mod/modpost.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index:

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-10 Thread Andi Kleen
On Mon, Dec 10, 2007 at 07:50:08PM +0100, Sam Ravnborg wrote: On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Sorry must have been left out by mistake. Signed-off-by: Andi

[PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-11-21 Thread Andi Kleen
This way gcc can warn for wrong format strings --- scripts/mod/modpost.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux/scripts/mod/modpost.c === --- linux.orig/scripts/mod/modpost.c +++

[PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-11-21 Thread Andi Kleen
This way gcc can warn for wrong format strings --- scripts/mod/modpost.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: linux/scripts/mod/modpost.c === --- linux.orig/scripts/mod/modpost.c +++