Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-24 Thread Paul E. McKenney
On Fri, Aug 24, 2007 at 01:51:21PM +0530, Gautham R Shenoy wrote: > On Thu, Aug 23, 2007 at 08:55:26AM -0700, Paul E. McKenney wrote: > > > Even if we use another cpumask_t, whenever a cpu goes down or comes up, > > > that will be reflected in this map, no? So what's the additional > > > advantage

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-24 Thread Andy Whitcroft
Andrew Morton wrote: >> +for_each_possible_cpu(cpu) { >> +rbdp = per_cpu(rcu_boost_dat, cpu); >> +for (i = 0; i < RCU_BOOST_ELEMENTS; i++) { >> +rbdp[i].rbs_mutex = SPIN_LOCK_UNLOCKED; > > Doesn't this confound lockdep? We're supposed to use spin_

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-24 Thread Gautham R Shenoy
On Thu, Aug 23, 2007 at 08:55:26AM -0700, Paul E. McKenney wrote: > > Even if we use another cpumask_t, whenever a cpu goes down or comes up, > > that will be reflected in this map, no? So what's the additional > > advantage of using it? > > The additional map allows the code to use something othe

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-23 Thread Paul E. McKenney
On Thu, Aug 23, 2007 at 07:52:11PM +0530, Gautham R Shenoy wrote: > On Thu, Aug 23, 2007 at 06:15:01AM -0700, Paul E. McKenney wrote: > > On Thu, Aug 23, 2007 at 03:44:44PM +0530, Gautham R Shenoy wrote: > > > On Thu, Aug 23, 2007 at 01:54:56AM -0700, Paul E. McKenney wrote: > > > > On Thu, Aug 23,

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-23 Thread Gautham R Shenoy
On Thu, Aug 23, 2007 at 06:15:01AM -0700, Paul E. McKenney wrote: > On Thu, Aug 23, 2007 at 03:44:44PM +0530, Gautham R Shenoy wrote: > > On Thu, Aug 23, 2007 at 01:54:56AM -0700, Paul E. McKenney wrote: > > > On Thu, Aug 23, 2007 at 09:56:39AM +0530, Gautham R Shenoy wrote: > > > > > > > > I feel

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-23 Thread Paul E. McKenney
On Thu, Aug 23, 2007 at 03:44:44PM +0530, Gautham R Shenoy wrote: > On Thu, Aug 23, 2007 at 01:54:56AM -0700, Paul E. McKenney wrote: > > On Thu, Aug 23, 2007 at 09:56:39AM +0530, Gautham R Shenoy wrote: > > > > > > I feel we should still be able to use for_each_online_cpu(cpu) instead > > > of fo

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-23 Thread Gautham R Shenoy
On Thu, Aug 23, 2007 at 01:54:56AM -0700, Paul E. McKenney wrote: > On Thu, Aug 23, 2007 at 09:56:39AM +0530, Gautham R Shenoy wrote: > > > > I feel we should still be able to use for_each_online_cpu(cpu) instead > > of for_each_possible_cpu. Again, there's a good chance that I might > > be mistak

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-23 Thread Paul E. McKenney
On Thu, Aug 23, 2007 at 09:56:39AM +0530, Gautham R Shenoy wrote: > Hi Paul, > On Wed, Aug 22, 2007 at 12:02:54PM -0700, Paul E. McKenney wrote: > > +/* > > + * Print out RCU booster task statistics at the specified interval. > > + */ > > +static void rcu_boost_dat_stat_print(void) > > +{ > > +

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Gautham R Shenoy
Hi Paul, On Wed, Aug 22, 2007 at 12:02:54PM -0700, Paul E. McKenney wrote: > +/* > + * Print out RCU booster task statistics at the specified interval. > + */ > +static void rcu_boost_dat_stat_print(void) > +{ > + /* Three decimal digits per byte plus spacing per number and line. */ > + ch

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Paul E. McKenney
On Wed, Aug 22, 2007 at 02:41:54PM -0700, Andrew Morton wrote: > On Wed, 22 Aug 2007 14:22:16 -0700 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > On Wed, Aug 22, 2007 at 12:43:40PM -0700, Andrew Morton wrote: > > > On Wed, 22 Aug 2007 12:02:54 -0700 > > > "Paul E. McKenney" <[EMAIL PROTECT

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Andrew Morton
On Wed, 22 Aug 2007 14:22:16 -0700 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > On Wed, Aug 22, 2007 at 12:43:40PM -0700, Andrew Morton wrote: > > On Wed, 22 Aug 2007 12:02:54 -0700 > > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > > > Hello! > > > > > > This patch is a forward-port of

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Paul E. McKenney
On Wed, Aug 22, 2007 at 12:43:40PM -0700, Andrew Morton wrote: > On Wed, 22 Aug 2007 12:02:54 -0700 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > Hello! > > > > This patch is a forward-port of RCU priority boosting (described in > > http://lwn.net/Articles/220677/). It applies to 2.6.22

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Josh Triplett
On Wed, 2007-08-22 at 12:43 -0700, Andrew Morton wrote: > On Wed, 22 Aug 2007 12:02:54 -0700 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > This patch is a forward-port of RCU priority boosting (described in > > http://lwn.net/Articles/220677/). It applies to 2.6.22 on top of > > the patches

Re: [PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Andrew Morton
On Wed, 22 Aug 2007 12:02:54 -0700 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > Hello! > > This patch is a forward-port of RCU priority boosting (described in > http://lwn.net/Articles/220677/). It applies to 2.6.22 on top of > the patches sent in the http://lkml.org/lkml/2007/8/7/276 series

[PATCH RFC] Priority boosting for preemptible RCU

2007-08-22 Thread Paul E. McKenney
Hello! This patch is a forward-port of RCU priority boosting (described in http://lwn.net/Articles/220677/). It applies to 2.6.22 on top of the patches sent in the http://lkml.org/lkml/2007/8/7/276 series and the hotplug patch (http://lkml.org/lkml/2007/8/17/262). Passes several hours of rcutort