Re: [PATCH RFC] Remove useless return variables

2014-05-23 Thread Jeff Kirsher
On Sun, May 18, 2014 at 5:14 AM, Peter Senna Tschudin wrote: > Added CC: triv...@vger.kernel.org > > On Sun, May 18, 2014 at 7:04 AM, Andi Kleen wrote: >> Peter Senna Tschudin writes: >> >>> This patch remove variables that are initialized with a constant, >>> are never updated, and are only use

Re: [PATCH RFC] Remove useless return variables

2014-05-18 Thread Peter Senna Tschudin
Added CC: triv...@vger.kernel.org On Sun, May 18, 2014 at 7:04 AM, Andi Kleen wrote: > Peter Senna Tschudin writes: > >> This patch remove variables that are initialized with a constant, >> are never updated, and are only used as parameter of return. >> Return the constant instead of using a var

Re: [PATCH RFC] Remove useless return variables

2014-05-18 Thread Dan Carpenter
On Sat, May 17, 2014 at 10:04:35PM -0700, Andi Kleen wrote: > Peter Senna Tschudin writes: > > > This patch remove variables that are initialized with a constant, > > are never updated, and are only used as parameter of return. > > Return the constant instead of using a variable. > > This ret va

Re: [PATCH RFC] Remove useless return variables

2014-05-17 Thread Andi Kleen
Peter Senna Tschudin writes: > This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable. This ret variable pattern is pretty standard in Linux, as it makes it easier to add