Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-18 Thread Marek Vasut
On Thursday, December 18, 2014 at 04:58:28 PM, Stefan Wahren wrote: > Hi Marek, Hello Stefan, > Am 17.12.2014 um 17:00 schrieb Marek Vasut: > > On Wednesday, December 17, 2014 at 08:58:23 AM, Stefan Wahren wrote: > >> Hi Fabio, > >> > >> Am 17.12.2014 um 03:44 schrieb Fabio Estevam: > >>> Hi Ste

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-18 Thread Stefan Wahren
Hi Marek, Am 17.12.2014 um 17:00 schrieb Marek Vasut: > On Wednesday, December 17, 2014 at 08:58:23 AM, Stefan Wahren wrote: >> Hi Fabio, >> >> Am 17.12.2014 um 03:44 schrieb Fabio Estevam: >>> Hi Stefan, >>> >>> On Sun, Dec 14, 2014 at 3:16 PM, Stefan Wahren > wrote: Btw i hope this patch

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-17 Thread Marek Vasut
On Wednesday, December 17, 2014 at 08:58:23 AM, Stefan Wahren wrote: > Hi Fabio, > > Am 17.12.2014 um 03:44 schrieb Fabio Estevam: > > Hi Stefan, > > > > On Sun, Dec 14, 2014 at 3:16 PM, Stefan Wahren wrote: > >> Btw i hope this patch also fixes a SPI communication issue with our > >> hardware

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-16 Thread Stefan Wahren
Hi Fabio, Am 17.12.2014 um 03:44 schrieb Fabio Estevam: > Hi Stefan, > > On Sun, Dec 14, 2014 at 3:16 PM, Stefan Wahren wrote: > >> Btw i hope this patch also fixes a SPI communication issue with our hardware >> which forces us to bypass ref_io1 for ssp2. > Does this patch fix the SPI issue? unf

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-16 Thread Fabio Estevam
Hi Stefan, On Sun, Dec 14, 2014 at 3:16 PM, Stefan Wahren wrote: > Btw i hope this patch also fixes a SPI communication issue with our hardware > which forces us to bypass ref_io1 for ssp2. Does this patch fix the SPI issue? -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-14 Thread Stefan Wahren
Hi, Am 14.12.2014 um 20:19 schrieb Marek Vasut: > On Sunday, December 14, 2014 at 06:16:17 PM, Stefan Wahren wrote: >>> [...] >>> >>> Also, it might be a good idea to zap the 0x3f mask and use HEX and DEC >>> numbers consistently, but this is an idea for another patch. >> Yes. >> >> Btw i hope thi

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-14 Thread Marek Vasut
On Sunday, December 14, 2014 at 06:16:17 PM, Stefan Wahren wrote: > Hi Marek, > > > Marek Vasut hat am 14. Dezember 2014 um 17:12 geschrieben: > > > static void __iomem *digctrl; > > > #define DIGCTRL digctrl > > > @@ -118,11 +119,12 @@ static void __init clk_misc_init(void) > > > /* > > > * 480

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-14 Thread Stefan Wahren
Hi Marek, > Marek Vasut hat am 14. Dezember 2014 um 17:12 geschrieben: > > > > > static void __iomem *digctrl; > > #define DIGCTRL digctrl > > @@ -118,11 +119,12 @@ static void __init clk_misc_init(void) > > /* > > * 480 MHz seems too high to be ssp clock source directly, > > * so set frac0 to ge

Re: [PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-14 Thread Marek Vasut
On Sunday, December 14, 2014 at 04:28:53 PM, Stefan Wahren wrote: > According to i.MX23 and i.MX28 reference manual the fractional > clock control registers must be addressed by byte instructions. > > This patch fixes the erroneous 32-bit access to these registers. > > The changes has been tested

[PATCH RFC] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-14 Thread Stefan Wahren
According to i.MX23 and i.MX28 reference manual the fractional clock control registers must be addressed by byte instructions. This patch fixes the erroneous 32-bit access to these registers. The changes has been tested only with a i.MX28 board, because i don't have access to an i.MX23 board. Si