Re: [PATCH RFC] compat: Get rid of (get|put)_compat_time(val|spec)

2014-02-02 Thread H. Peter Anvin
On 02/02/2014 11:08 AM, Linus Torvalds wrote: > On Sat, Feb 1, 2014 at 7:03 PM, H. Peter Anvin wrote: >> >> Clean it up by favoring the full-service version; the limited version >> is replaced with double-underscore versions static to kernel/compat.c. > > Ack. Make it so. I assume you've tested

Re: [PATCH RFC] compat: Get rid of (get|put)_compat_time(val|spec)

2014-02-02 Thread Linus Torvalds
On Sat, Feb 1, 2014 at 7:03 PM, H. Peter Anvin wrote: > > Clean it up by favoring the full-service version; the limited version > is replaced with double-underscore versions static to kernel/compat.c. Ack. Make it so. I assume you've tested this on x32 (and hopefully x86-32 on a 64-bit kernel),

Re: [PATCH RFC] compat: Get rid of (get|put)_compat_time(val|spec)

2014-02-02 Thread Linus Torvalds
On Sat, Feb 1, 2014 at 7:03 PM, H. Peter Anvin h...@linux.intel.com wrote: Clean it up by favoring the full-service version; the limited version is replaced with double-underscore versions static to kernel/compat.c. Ack. Make it so. I assume you've tested this on x32 (and hopefully x86-32 on a

Re: [PATCH RFC] compat: Get rid of (get|put)_compat_time(val|spec)

2014-02-02 Thread H. Peter Anvin
On 02/02/2014 11:08 AM, Linus Torvalds wrote: On Sat, Feb 1, 2014 at 7:03 PM, H. Peter Anvin h...@linux.intel.com wrote: Clean it up by favoring the full-service version; the limited version is replaced with double-underscore versions static to kernel/compat.c. Ack. Make it so. I assume

[PATCH RFC] compat: Get rid of (get|put)_compat_time(val|spec)

2014-02-01 Thread H. Peter Anvin
From: "H. Peter Anvin" We have two APIs for compatiblity timespec/val, with confusingly similar names. compat_(get|put)_time(val|spec) *do* handle the case where COMPAT_USE_64BIT_TIME is set, whereas (get|put)_compat_time(val|spec) do not. This is an accident waiting to happen. Clean it up by

[PATCH RFC] compat: Get rid of (get|put)_compat_time(val|spec)

2014-02-01 Thread H. Peter Anvin
From: H. Peter Anvin h...@linux.intel.com We have two APIs for compatiblity timespec/val, with confusingly similar names. compat_(get|put)_time(val|spec) *do* handle the case where COMPAT_USE_64BIT_TIME is set, whereas (get|put)_compat_time(val|spec) do not. This is an accident waiting to