Re: [PATCH RFC] cred: Add WARN to detect wrong use of get/put_cred

2020-06-12 Thread Kees Cook
On Fri, Jun 12, 2020 at 06:33:45PM +0200, Peter Zijlstra wrote: > On Fri, Jun 12, 2020 at 06:28:15PM +0800, Xiaoming Ni wrote: > > Cred release and usage check code flow: > > 1. put_cred() > > if (atomic_dec_and_test(&(cred)->usage)) > > __put_cred(cred); > > >

Re: [PATCH RFC] cred: Add WARN to detect wrong use of get/put_cred

2020-06-12 Thread Peter Zijlstra
On Fri, Jun 12, 2020 at 06:28:15PM +0800, Xiaoming Ni wrote: > Cred release and usage check code flow: > 1. put_cred() > if (atomic_dec_and_test(&(cred)->usage)) > __put_cred(cred); > > 2. __put_cred() > BUG_ON(atomic_read(&cred->usage)

Re: [PATCH RFC] cred: Add WARN to detect wrong use of get/put_cred

2020-06-12 Thread Eric Dumazet
On Fri, Jun 12, 2020 at 3:28 AM Xiaoming Ni wrote: > > Cred release and usage check code flow: > 1. put_cred() > if (atomic_dec_and_test(&(cred)->usage)) > __put_cred(cred); > > 2. __put_cred() > BUG_ON(atomic_read(&cred->usag

RE: [PATCH RFC] cred: Add WARN to detect wrong use of get/put_cred

2020-06-12 Thread David Laight
From: Xiaoming Ni > Sent: 12 June 2020 11:28 > Cred release and usage check code flow: > 1. put_cred() > if (atomic_dec_and_test(&(cred)->usage)) > __put_cred(cred); > > 2. __put_cred() > BUG_ON(atomic_read(&cred->usage) != 0); >

[PATCH RFC] cred: Add WARN to detect wrong use of get/put_cred

2020-06-12 Thread Xiaoming Ni
Cred release and usage check code flow: 1. put_cred() if (atomic_dec_and_test(&(cred)->usage)) __put_cred(cred); 2. __put_cred() BUG_ON(atomic_read(&cred->usage) != 0); call_rcu(&cred->rcu, put_cred_rcu);