Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-09 Thread Mark Brown
On Mon, Nov 09, 2020 at 11:25:39AM -0600, Rob Herring wrote: > On Fri, Nov 6, 2020 at 1:09 PM Saravana Kannan wrote: > > And all the subsystems that create their own device from an of_node > > should use of_set_device_of_node() to set the device's of_node. That > > way, all this is done in a cons

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-09 Thread Rob Herring
On Fri, Nov 6, 2020 at 1:09 PM Saravana Kannan wrote: > > +Rob and Frank > > On Fri, Nov 6, 2020 at 7:09 AM Mark Brown wrote: > > > > Currently the fwnode API and things that rely on it like fw_devlink will > > not reliably work for devices created from DT since each subsystem that > > creates de

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-09 Thread Mark Brown
On Fri, Nov 06, 2020 at 05:55:10PM -0800, Saravana Kannan wrote: > On Fri, Nov 6, 2020 at 11:23 AM Mark Brown wrote: > > That also sounds good, particularly if we have a coccinelle spatch > I've never used coccinelle. But I can fix 5-10 easily findable ones > like i2c, platform, spi, slimbus, sp

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Saravana Kannan
On Fri, Nov 6, 2020 at 11:23 AM Mark Brown wrote: > > On Fri, Nov 06, 2020 at 11:09:17AM -0800, Saravana Kannan wrote: > > > If you want to do this in "one common place", then I think the way to > > do this is have include/linux/of.h provide something like: > > > void of_set_device_of_node(dev, of

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Mark Brown
On Fri, Nov 06, 2020 at 11:09:17AM -0800, Saravana Kannan wrote: > If you want to do this in "one common place", then I think the way to > do this is have include/linux/of.h provide something like: > void of_set_device_of_node(dev, of_node) > { > dev->of_node = of_node; > dev->fw_node = &

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Saravana Kannan
+Rob and Frank On Fri, Nov 6, 2020 at 7:09 AM Mark Brown wrote: > > Currently the fwnode API and things that rely on it like fw_devlink will > not reliably work for devices created from DT since each subsystem that > creates devices must individually set dev->fwnode in addition to setting > dev->

[PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Mark Brown
Currently the fwnode API and things that rely on it like fw_devlink will not reliably work for devices created from DT since each subsystem that creates devices must individually set dev->fwnode in addition to setting dev->of_node, currently a number of subsystems don't do so. Ensure that this can'