Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-05 Thread Nicholas Mc Guire
On Wed, Jul 05, 2017 at 06:06:09PM +0800, Jonathan Cameron wrote: > On Wed, 5 Jul 2017 08:55:47 + > Nicholas Mc Guire wrote: > > > On Wed, Jul 05, 2017 at 10:02:17AM +0200, Geert Uytterhoeven wrote: > > > Hi Nicholas, > > > > > > On Wed, Jul 5, 2017 at 9:37 AM, Nicholas Mc Guire > > > wrote

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-05 Thread Jonathan Cameron
On Wed, 5 Jul 2017 08:55:47 + Nicholas Mc Guire wrote: > On Wed, Jul 05, 2017 at 10:02:17AM +0200, Geert Uytterhoeven wrote: > > Hi Nicholas, > > > > On Wed, Jul 5, 2017 at 9:37 AM, Nicholas Mc Guire > > wrote: > > > On Tue, Jul 04, 2017 at 08:08:53PM +0100, Jonathan Cameron > > > wrote:

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-05 Thread Nicholas Mc Guire
On Wed, Jul 05, 2017 at 10:02:17AM +0200, Geert Uytterhoeven wrote: > Hi Nicholas, > > On Wed, Jul 5, 2017 at 9:37 AM, Nicholas Mc Guire wrote: > > On Tue, Jul 04, 2017 at 08:08:53PM +0100, Jonathan Cameron wrote: > >> On Tue, 4 Jul 2017 12:40:33 +0200 > >> Geert Uytterhoeven wrote: > >> > On Su

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-05 Thread Jonathan Cameron
On Wed, 5 Jul 2017 07:37:05 + Nicholas Mc Guire wrote: > On Tue, Jul 04, 2017 at 08:08:53PM +0100, Jonathan Cameron wrote: > > On Tue, 4 Jul 2017 12:40:33 +0200 > > Geert Uytterhoeven wrote: > > > > > Hi Nicholas, > > > > > > On Sun, May 14, 2017 at 10:43 AM, Nicholas Mc Guire > > > wro

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-05 Thread Geert Uytterhoeven
Hi Nicholas, On Wed, Jul 5, 2017 at 9:37 AM, Nicholas Mc Guire wrote: > On Tue, Jul 04, 2017 at 08:08:53PM +0100, Jonathan Cameron wrote: >> On Tue, 4 Jul 2017 12:40:33 +0200 >> Geert Uytterhoeven wrote: >> > On Sun, May 14, 2017 at 10:43 AM, Nicholas Mc Guire >> > wrote: >> > > If the timeout

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-05 Thread Nicholas Mc Guire
On Tue, Jul 04, 2017 at 08:08:53PM +0100, Jonathan Cameron wrote: > On Tue, 4 Jul 2017 12:40:33 +0200 > Geert Uytterhoeven wrote: > > > Hi Nicholas, > > > > On Sun, May 14, 2017 at 10:43 AM, Nicholas Mc Guire > > wrote: > > > If the timeout-case prints a warning message then probably the inter

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-04 Thread Jonathan Cameron
On Tue, 4 Jul 2017 12:40:33 +0200 Geert Uytterhoeven wrote: > Hi Nicholas, > > On Sun, May 14, 2017 at 10:43 AM, Nicholas Mc Guire wrote: > > If the timeout-case prints a warning message then probably the interrupted > > case should also. Further, wait_for_completion_interruptible_timeout() > >

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-07-04 Thread Geert Uytterhoeven
Hi Nicholas, On Sun, May 14, 2017 at 10:43 AM, Nicholas Mc Guire wrote: > If the timeout-case prints a warning message then probably the interrupted > case should also. Further, wait_for_completion_interruptible_timeout() > returns long not int. > > Fixes: commit 03b262f2bbf4 ("iio:pressure: init

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-05-14 Thread Jonathan Cameron
On 14/05/17 10:46, Peter Meerwald-Stadler wrote: If the timeout-case prints a warning message then probably the interrupted case should also. Further, wait_for_completion_interruptible_timeout() returns long not int. Fixes: commit 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support"

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-05-14 Thread Nicholas Mc Guire
On Sun, May 14, 2017 at 11:46:58AM +0200, Peter Meerwald-Stadler wrote: > > > If the timeout-case prints a warning message then probably the interrupted > > case should also. Further, wait_for_completion_interruptible_timeout() > > returns long not int. > > > > Fixes: commit 03b262f2bbf4 ("iio:p

Re: [PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-05-14 Thread Peter Meerwald-Stadler
> If the timeout-case prints a warning message then probably the interrupted > case should also. Further, wait_for_completion_interruptible_timeout() > returns long not int. > > Fixes: commit 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support") > Signed-off-by: Nicholas Mc Guire th

[PATCH RFC] iio: pressure: zpa2326: report interrupted case as failure

2017-05-14 Thread Nicholas Mc Guire
If the timeout-case prints a warning message then probably the interrupted case should also. Further, wait_for_completion_interruptible_timeout() returns long not int. Fixes: commit 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support") Signed-off-by: Nicholas Mc Guire --- The origina