Re: [PATCH RFC] mm/memcg: recalculate chargeable space after waiting migrating charges

2012-07-12 Thread Wanpeng Li
On Thu, Jul 12, 2012 at 02:29:38PM +0200, Michal Hocko wrote: >On Thu 12-07-12 19:51:25, Wanpeng Li wrote: >> On Thu, Jul 12, 2012 at 01:08:38PM +0200, Michal Hocko wrote: >> >On Thu 12-07-12 18:39:21, Wanpeng Li wrote: >> >> From: Wanpeng Li >> >> >> >> Function mem_cgroup_do_charge will call me

Re: [PATCH RFC] mm/memcg: recalculate chargeable space after waiting migrating charges

2012-07-12 Thread Michal Hocko
On Thu 12-07-12 19:51:25, Wanpeng Li wrote: > On Thu, Jul 12, 2012 at 01:08:38PM +0200, Michal Hocko wrote: > >On Thu 12-07-12 18:39:21, Wanpeng Li wrote: > >> From: Wanpeng Li > >> > >> Function mem_cgroup_do_charge will call mem_cgroup_reclaim, > >> there are two break points in mem_cgroup_recl

Re: [PATCH RFC] mm/memcg: recalculate chargeable space after waiting migrating charges

2012-07-12 Thread Wanpeng Li
On Thu, Jul 12, 2012 at 01:08:38PM +0200, Michal Hocko wrote: >On Thu 12-07-12 18:39:21, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Function mem_cgroup_do_charge will call mem_cgroup_reclaim, >> there are two break points in mem_cgroup_reclaim: >> if (total && (flag & MEM_CGROUP_RECLAIM_SHIRINK)

Re: [PATCH RFC] mm/memcg: recalculate chargeable space after waiting migrating charges

2012-07-12 Thread Michal Hocko
On Thu 12-07-12 18:39:21, Wanpeng Li wrote: > From: Wanpeng Li > > Function mem_cgroup_do_charge will call mem_cgroup_reclaim, > there are two break points in mem_cgroup_reclaim: > if (total && (flag & MEM_CGROUP_RECLAIM_SHIRINK)) > break; > if (mem_cgroup_margin(memcg)) > break; > so

[PATCH RFC] mm/memcg: recalculate chargeable space after waiting migrating charges

2012-07-12 Thread Wanpeng Li
From: Wanpeng Li Function mem_cgroup_do_charge will call mem_cgroup_reclaim, there are two break points in mem_cgroup_reclaim: if (total && (flag & MEM_CGROUP_RECLAIM_SHIRINK)) break; if (mem_cgroup_margin(memcg)) break; so mem_cgroup_reclaim can't guarantee reclaim enough pages(n