Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-29 Thread David Miller
From: One Thousand Gnomes Date: Wed, 29 Apr 2015 11:15:21 +0100 >> Unfortunately, the Cadence MACB doesn't support the enabling or >> disabling of checksum generation per descriptor. > > So how does packet forwarding work ? Yeah actually rechecksumming in that scenerio is illegal. -- To unsubs

Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-29 Thread One Thousand Gnomes
> Unfortunately, the Cadence MACB doesn't support the enabling or > disabling of checksum generation per descriptor. So how does packet forwarding work ? If that means the device is re-checksumming packets it is forwarding then that's really not very good at all, especially if it takes frames that

Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-28 Thread David Miller
From: Jaeden Amero Date: Tue, 28 Apr 2015 15:36:54 -0500 > On 04/27/2015 09:47 PM, David Miller wrote: >> From: Jaeden Amero >> Date: Mon, 27 Apr 2015 17:43:30 -0500 >> >> A UDP checksum of zero, means "checksum not computed". And your >> device isn't computing the checksum at all, but rather i

Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-28 Thread Jaeden Amero
On 04/27/2015 09:47 PM, David Miller wrote: > From: Jaeden Amero > Date: Mon, 27 Apr 2015 17:43:30 -0500 > > A UDP checksum of zero, means "checksum not computed". And your > device isn't computing the checksum at all, but rather is leaving it > at zero. The "zero" checksum is not what gets sent

Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-27 Thread David Miller
From: Jaeden Amero Date: Mon, 27 Apr 2015 17:43:30 -0500 > If we set the checksum field in the UDP header to 0, the checksum is > computed correctly. I think this is completely bogus. A UDP checksum of zero, means "checksum not computed". And your device isn't computing the checksum at all, bu

[PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-27 Thread Jaeden Amero
From: Jeff Westfahl Some Cadence MACB hardware generates incorrect UDP checksums for outgoing UDP packets with a payload of 2 bytes of less. If the UDP data payload is 0, 1 or 2 bytes, transmit checksum offloading can compute an incorrect UDPv4 header checksum (e.g. 0x). If we set the checksu