Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-07 Thread Luiz Capitulino
On Tue, 31 Mar 2015 20:18:36 -0300 Marcelo Tosatti wrote: > On Tue, Mar 31, 2015 at 05:02:38PM +0200, Frederic Weisbecker wrote: > > On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: > > > CPUs with nohz_full do not want disruption from timer interrupts, > > > or other random system

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-07 Thread Luiz Capitulino
On Tue, 31 Mar 2015 20:18:36 -0300 Marcelo Tosatti mtosa...@redhat.com wrote: On Tue, Mar 31, 2015 at 05:02:38PM +0200, Frederic Weisbecker wrote: On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-04 Thread Mike Galbraith
On Tue, 2015-03-31 at 10:27 -0400, Rik van Riel wrote: > CPUs with nohz_full do not want disruption from timer interrupts, > or other random system things. This includes block mq work. > > There is another issue with block mq vs. realtime tasks that run > 100% of the time, which is not uncommon

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-04 Thread Mike Galbraith
On Tue, 2015-03-31 at 10:27 -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not uncommon on

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-02 Thread Jens Axboe
On 04/01/2015 10:12 AM, Rik van Riel wrote: On 03/31/2015 11:43 AM, Jens Axboe wrote: That'd be easy enough to do, that's how blk-mq handles offline CPUs as well. The attached patch is completely untested, but will handle offline or nohz CPUs in the same fashion - they will punt to hardware

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-02 Thread Jens Axboe
On 04/01/2015 10:12 AM, Rik van Riel wrote: On 03/31/2015 11:43 AM, Jens Axboe wrote: That'd be easy enough to do, that's how blk-mq handles offline CPUs as well. The attached patch is completely untested, but will handle offline or nohz CPUs in the same fashion - they will punt to hardware

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Rik van Riel
On 03/31/2015 11:43 AM, Jens Axboe wrote: > That'd be easy enough to do, that's how blk-mq handles offline CPUs as > well. The attached patch is completely untested, but will handle offline > or nohz CPUs in the same fashion - they will punt to hardware queue 0, > which is mapped to CPU0 (and

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Jens Axboe
On 04/01/2015 08:45 AM, Rik van Riel wrote: On 04/01/2015 10:36 AM, Jens Axboe wrote: That wont work for blk-mq, we rely on the characteristics of bound workqueues. So it would have to be handled up front, like in the patch I sent out. Your patch from yesterday looks good. I'll take it for

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Rik van Riel
On 04/01/2015 10:36 AM, Jens Axboe wrote: That wont work for blk-mq, we rely on the characteristics of bound workqueues. So it would have to be handled up front, like in the patch I sent out. Your patch from yesterday looks good. I'll take it for a spin today (had some other stuff on my

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Jens Axboe
On 03/31/2015 05:17 PM, Marcelo Tosatti wrote: On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Jens Axboe
On 03/31/2015 05:17 PM, Marcelo Tosatti wrote: On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Rik van Riel
On 04/01/2015 10:36 AM, Jens Axboe wrote: That wont work for blk-mq, we rely on the characteristics of bound workqueues. So it would have to be handled up front, like in the patch I sent out. Your patch from yesterday looks good. I'll take it for a spin today (had some other stuff on my

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Jens Axboe
On 04/01/2015 08:45 AM, Rik van Riel wrote: On 04/01/2015 10:36 AM, Jens Axboe wrote: That wont work for blk-mq, we rely on the characteristics of bound workqueues. So it would have to be handled up front, like in the patch I sent out. Your patch from yesterday looks good. I'll take it for

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-04-01 Thread Rik van Riel
On 03/31/2015 11:43 AM, Jens Axboe wrote: That'd be easy enough to do, that's how blk-mq handles offline CPUs as well. The attached patch is completely untested, but will handle offline or nohz CPUs in the same fashion - they will punt to hardware queue 0, which is mapped to CPU0 (and others,

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Marcelo Tosatti
On Tue, Mar 31, 2015 at 05:02:38PM +0200, Frederic Weisbecker wrote: > On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: > > CPUs with nohz_full do not want disruption from timer interrupts, > > or other random system things. This includes block mq work. > > > > There is another

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Marcelo Tosatti
On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: > CPUs with nohz_full do not want disruption from timer interrupts, > or other random system things. This includes block mq work. > > There is another issue with block mq vs. realtime tasks that run > 100% of the time, which is not

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Jens Axboe
On 03/31/2015 09:33 AM, Frederic Weisbecker wrote: On Tue, Mar 31, 2015 at 09:07:11AM -0600, Jens Axboe wrote: On 03/31/2015 08:27 AM, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Frederic Weisbecker
On Tue, Mar 31, 2015 at 09:07:11AM -0600, Jens Axboe wrote: > On 03/31/2015 08:27 AM, Rik van Riel wrote: > >CPUs with nohz_full do not want disruption from timer interrupts, > >or other random system things. This includes block mq work. > > > >There is another issue with block mq vs. realtime

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Jens Axboe
On 03/31/2015 08:27 AM, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not uncommon on systems that

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Frederic Weisbecker
On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: > CPUs with nohz_full do not want disruption from timer interrupts, > or other random system things. This includes block mq work. > > There is another issue with block mq vs. realtime tasks that run > 100% of the time, which is not

[PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Rik van Riel
CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not uncommon on systems that have CPUs dedicated to real time use with

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Marcelo Tosatti
On Tue, Mar 31, 2015 at 05:02:38PM +0200, Frederic Weisbecker wrote: On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Marcelo Tosatti
On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not

[PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Rik van Riel
CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not uncommon on systems that have CPUs dedicated to real time use with

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Jens Axboe
On 03/31/2015 08:27 AM, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not uncommon on systems that

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Jens Axboe
On 03/31/2015 09:33 AM, Frederic Weisbecker wrote: On Tue, Mar 31, 2015 at 09:07:11AM -0600, Jens Axboe wrote: On 03/31/2015 08:27 AM, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Frederic Weisbecker
On Tue, Mar 31, 2015 at 10:27:26AM -0400, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that run 100% of the time, which is not

Re: [PATCH RFC] nohz,blk-mq: do not create blk-mq workqueues on nohz dedicated CPUs

2015-03-31 Thread Frederic Weisbecker
On Tue, Mar 31, 2015 at 09:07:11AM -0600, Jens Axboe wrote: On 03/31/2015 08:27 AM, Rik van Riel wrote: CPUs with nohz_full do not want disruption from timer interrupts, or other random system things. This includes block mq work. There is another issue with block mq vs. realtime tasks that