Re: [PATCH RFC] pwm: add sysfs interface

2013-03-05 Thread Greg KH
On Tue, Mar 05, 2013 at 03:46:13PM +0100, Lars Poeschel wrote: > At first: Thanks for your review! > > On Monday 25 February 2013 at 05:00:25, Greg KH wrote: > > On Tue, Feb 19, 2013 at 03:27:41PM +0100, Lars Poeschel wrote: > > > +static int pwmchip_export(struct pwm_chip *chip) > > > +{ > > > +

Re: [PATCH RFC] pwm: add sysfs interface

2013-03-05 Thread Lars Poeschel
At first: Thanks for your review! On Monday 25 February 2013 at 05:00:25, Greg KH wrote: > On Tue, Feb 19, 2013 at 03:27:41PM +0100, Lars Poeschel wrote: > > +static int pwmchip_export(struct pwm_chip *chip) > > +{ > > + int status; > > + struct device *dev; > > + > > + mutex_lock(&sysfs_loc

Re: [PATCH RFC] pwm: add sysfs interface

2013-03-04 Thread Lars Poeschel
On Sunday 24 February 2013 at 01:14:48, Rob Landley wrote: > On 02/19/2013 08:27:41 AM, Lars Poeschel wrote: > > From: Lars Poeschel > > > > This adds a simple sysfs interface to the pwm subsystem. It is > > heavily inspired by the gpio sysfs interface. > > Docs! This means I have to add more i

Re: [PATCH RFC] pwm: add sysfs interface

2013-02-24 Thread Greg KH
On Tue, Feb 19, 2013 at 03:27:41PM +0100, Lars Poeschel wrote: > +static int pwmchip_export(struct pwm_chip *chip) > +{ > + int status; > + struct device *dev; > + > + mutex_lock(&sysfs_lock); > + dev = device_create(&pwm_class, chip->dev, MKDEV(0, 0), chip, > +

Re: [PATCH RFC] pwm: add sysfs interface

2013-02-24 Thread Greg KH
On Tue, Feb 19, 2013 at 03:27:41PM +0100, Lars Poeschel wrote: > From: Lars Poeschel > > This adds a simple sysfs interface to the pwm subsystem. It is > heavily inspired by the gpio sysfs interface. > > /sys/class/pwm > /export ... asks the kernel to export a PWM to user

Re: [PATCH RFC] pwm: add sysfs interface

2013-02-23 Thread Rob Landley
On 02/19/2013 08:27:41 AM, Lars Poeschel wrote: From: Lars Poeschel This adds a simple sysfs interface to the pwm subsystem. It is heavily inspired by the gpio sysfs interface. Docs! diff --git a/Documentation/pwm.txt b/Documentation/pwm.txt index 7d2b4c9..b349d16 100644 --- a/Documentation

[PATCH RFC] pwm: add sysfs interface

2013-02-19 Thread Lars Poeschel
From: Lars Poeschel This adds a simple sysfs interface to the pwm subsystem. It is heavily inspired by the gpio sysfs interface. /sys/class/pwm /export ... asks the kernel to export a PWM to userspace /unexport ... to return a PWM to the kernel