Re: [PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-18 Thread Vlad Yasevich
On 02/18/2014 10:39 AM, David Laight wrote: >>> + >>> + /* Update the heartbeat timer immediately. */ >>> + if (!mod_timer(&trans->hb_timer, >>> + sctp_transport_timeout(trans))) >>> +

RE: [PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-18 Thread David Laight
> > + > > + /* Update the heartbeat timer immediately. */ > > + if (!mod_timer(&trans->hb_timer, > > + sctp_transport_timeout(trans))) > > + sctp_transport_hold(trans); > > T

Re: [PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-18 Thread Vlad Yasevich
On 02/18/2014 12:56 AM, Xufeng Zhang wrote: > For an established association, if user has updated the HB.interval > parameter by setsockopt(), this new heartbeat interval will not > take effect until: > - the expiry of the heartbeat timer and new hearbeat is sent. > - DATA chunk has been sent a

Re: [PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-18 Thread Neil Horman
On Tue, Feb 18, 2014 at 01:56:50PM +0800, Xufeng Zhang wrote: > For an established association, if user has updated the HB.interval > parameter by setsockopt(), this new heartbeat interval will not > take effect until: > - the expiry of the heartbeat timer and new hearbeat is sent. > - DATA chu

[PATCH RFC] sctp: Update HEARTBEAT timer immediately after user changed HB.interval

2014-02-17 Thread Xufeng Zhang
For an established association, if user has updated the HB.interval parameter by setsockopt(), this new heartbeat interval will not take effect until: - the expiry of the heartbeat timer and new hearbeat is sent. - DATA chunk has been sent and the transport resets the timer. This could not meet