Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-19 Thread Paolo Valente
> Il giorno 18 mar 2017, alle ore 11:24, Bart Van Assche > ha scritto: > > On Sat, 2017-03-18 at 08:08 -0400, Paolo Valente wrote: >>> Il giorno 06 mar 2017, alle ore 14:40, Bart Van Assche >>> ha scritto: +#define BFQ_BFQQ_FNS(name) \

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-18 Thread Bart Van Assche
On Sat, 2017-03-18 at 08:08 -0400, Paolo Valente wrote: > > Il giorno 06 mar 2017, alle ore 14:40, Bart Van Assche > > ha scritto: > > > +#define BFQ_BFQQ_FNS(name) > > > \ > > > +static void bfq_mark_bfqq_##name(struct bfq_queue *bfqq) \ > >

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-18 Thread Paolo Valente
> Il giorno 07 mar 2017, alle ore 18:22, Jens Axboe ha > scritto: > >> +/** >> + * bfq_entity_of - get an entity from a node. >> + * @node: the node field of the entity. >> + * >> + * Convert a node pointer to the relative entity. This is used only >> + * to simplify the logic of some function

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-18 Thread Paolo Valente
> Il giorno 06 mar 2017, alle ore 14:40, Bart Van Assche > ha scritto: > > On 03/04/2017 08:01 AM, Paolo Valente wrote: >> BFQ is a proportional-share I/O scheduler, whose general structure, >> plus a lot of code, are borrowed from CFQ. >> [ ... ] > Hi Bart, I'll reply below only to the recom

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-14 Thread Paolo Valente
> Il giorno 06 mar 2017, alle ore 20:40, Bart Van Assche > ha scritto: > Hi Bart, thanks for such an accurate review. I'm addressing the issues you raised, and I'll get back in touch as soon as I have finished. Paolo > On 03/04/2017 08:01 AM, Paolo Valente wrote: >> BFQ is a proportional-sh

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-14 Thread Paolo Valente
> Il giorno 06 mar 2017, alle ore 21:46, Jens Axboe ha > scritto: > > On 03/05/2017 09:02 AM, Paolo Valente wrote: >> >>> Il giorno 05 mar 2017, alle ore 16:16, Jens Axboe ha >>> scritto: >>> >>> On 03/04/2017 09:01 AM, Paolo Valente wrote: We tag as v0 the version of BFQ containing on

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-07 Thread Jens Axboe
> +/** > + * bfq_entity_of - get an entity from a node. > + * @node: the node field of the entity. > + * > + * Convert a node pointer to the relative entity. This is used only > + * to simplify the logic of some functions and not as the generic > + * conversion mechanism because, e.g., in the tree

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-06 Thread Jens Axboe
On 03/05/2017 09:02 AM, Paolo Valente wrote: > >> Il giorno 05 mar 2017, alle ore 16:16, Jens Axboe ha >> scritto: >> >> On 03/04/2017 09:01 AM, Paolo Valente wrote: >>> We tag as v0 the version of BFQ containing only BFQ's engine plus >>> hierarchical support. BFQ's engine is introduced by this

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-06 Thread Bart Van Assche
On 03/04/2017 08:01 AM, Paolo Valente wrote: > BFQ is a proportional-share I/O scheduler, whose general structure, > plus a lot of code, are borrowed from CFQ. > [ ... ] This description is very useful. However, since it is identical to the description this patch adds to Documentation/block/bfq-io

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-05 Thread Paolo Valente
> Il giorno 05 mar 2017, alle ore 16:16, Jens Axboe ha > scritto: > > On 03/04/2017 09:01 AM, Paolo Valente wrote: >> We tag as v0 the version of BFQ containing only BFQ's engine plus >> hierarchical support. BFQ's engine is introduced by this commit, while >> hierarchical support is added by n

Re: [PATCH RFC 01/14] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler

2017-03-05 Thread Jens Axboe
On 03/04/2017 09:01 AM, Paolo Valente wrote: > We tag as v0 the version of BFQ containing only BFQ's engine plus > hierarchical support. BFQ's engine is introduced by this commit, while > hierarchical support is added by next commit. We use the v0 tag to > distinguish this minimal version of BFQ fr