Re: [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-03-06 Thread Roger Pau Monné
On 05/03/13 22:53, Konrad Rzeszutek Wilk wrote: >> >> /* No more gnttab callback work. */ >> gnttab_cancel_free_callback(&info->callback); >> @@ -1088,6 +1120,12 @@ again: >> goto destroy_blkring; >> } >> >> +/*

Re: [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 05:30:01PM +0100, Roger Pau Monné wrote: > On 05/03/13 15:18, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 05, 2013 at 12:04:41PM +0100, Roger Pau Monné wrote: > >> On 04/03/13 20:39, Konrad Rzeszutek Wilk wrote: > >>> On Thu, Feb 28, 2013 at 11:28:47AM +0100, Roger Pau Monn

Re: [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-03-05 Thread Roger Pau Monné
On 05/03/13 15:18, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 05, 2013 at 12:04:41PM +0100, Roger Pau Monné wrote: >> On 04/03/13 20:39, Konrad Rzeszutek Wilk wrote: >>> On Thu, Feb 28, 2013 at 11:28:47AM +0100, Roger Pau Monne wrote: This prevents us from having to call alloc_page while we ar

Re: [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 12:04:41PM +0100, Roger Pau Monné wrote: > On 04/03/13 20:39, Konrad Rzeszutek Wilk wrote: > > On Thu, Feb 28, 2013 at 11:28:47AM +0100, Roger Pau Monne wrote: > >> This prevents us from having to call alloc_page while we are preparing > >> the request. Since blkfront was ca

Re: [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-03-05 Thread Roger Pau Monné
On 04/03/13 20:39, Konrad Rzeszutek Wilk wrote: > On Thu, Feb 28, 2013 at 11:28:47AM +0100, Roger Pau Monne wrote: >> This prevents us from having to call alloc_page while we are preparing >> the request. Since blkfront was calling alloc_page with a spinlock >> held we used GFP_ATOMIC, which can fa

Re: [PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-03-04 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 11:28:47AM +0100, Roger Pau Monne wrote: > This prevents us from having to call alloc_page while we are preparing > the request. Since blkfront was calling alloc_page with a spinlock > held we used GFP_ATOMIC, which can fail if we are requesting a lot of > pages since it is

[PATCH RFC 04/12] xen-blkfront: pre-allocate pages for requests

2013-02-28 Thread Roger Pau Monne
This prevents us from having to call alloc_page while we are preparing the request. Since blkfront was calling alloc_page with a spinlock held we used GFP_ATOMIC, which can fail if we are requesting a lot of pages since it is using the emergency memory pools. Allocating all the pages at init preve