Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-25 Thread Sudeep Holla
On Fri, Jan 25, 2019 at 12:33:56PM +0530, Pramod Kumar wrote: [...] > > This is an GPIO interrupt. This can not be marked secure as for that > we need to mark whole GPIO controller as secure which is not possible > as GPIO controller is meant for non-secure world having more than 100 > lines

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-25 Thread Robin Murphy
On 25/01/2019 07:03, Pramod Kumar wrote: On Wed, Jan 23, 2019 at 11:03 PM Mark Rutland wrote: On Wed, Jan 23, 2019 at 09:05:26AM -0800, Scott Branden wrote: Hi Mark, Hopefully I can shed some light on the use case inline. On 2019-01-23 8:48 a.m., Mark Rutland wrote: On Mon, Jan 21, 2019

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-24 Thread Pramod Kumar
On Wed, Jan 23, 2019 at 11:03 PM Mark Rutland wrote: > > On Wed, Jan 23, 2019 at 09:05:26AM -0800, Scott Branden wrote: > > Hi Mark, > > > > Hopefully I can shed some light on the use case inline. > > > > On 2019-01-23 8:48 a.m., Mark Rutland wrote: > > > On Mon, Jan 21, 2019 at 11:30:02AM +0530,

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Sudeep Holla
On Wed, Jan 23, 2019 at 09:46:22AM -0800, Scott Branden wrote: [...] > > Some additional flags and details are saved to disk with the "pending i/o". > I am getting a sense that this is some raw partition on a disk(flash/eMMC/UFS) the M0 can write to and Linux can read. It's can't be full fledge

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Scott Branden
On 2019-01-23 9:33 a.m., Mark Rutland wrote: On Wed, Jan 23, 2019 at 09:05:26AM -0800, Scott Branden wrote: Hi Mark, Hopefully I can shed some light on the use case inline. On 2019-01-23 8:48 a.m., Mark Rutland wrote: On Mon, Jan 21, 2019 at 11:30:02AM +0530, Pramod Kumar wrote: On Mon, Jan

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Mark Rutland
On Wed, Jan 23, 2019 at 09:05:26AM -0800, Scott Branden wrote: > Hi Mark, > > Hopefully I can shed some light on the use case inline. > > On 2019-01-23 8:48 a.m., Mark Rutland wrote: > > On Mon, Jan 21, 2019 at 11:30:02AM +0530, Pramod Kumar wrote: > > > On Mon, Jan 21, 2019 at 11:28 AM Pramod

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Scott Branden
Hi Sudeep, On 2019-01-23 9:21 a.m., Sudeep Holla wrote: On Wed, Jan 23, 2019 at 09:05:26AM -0800, Scott Branden wrote: Hi Mark, Hopefully I can shed some light on the use case inline. On 2019-01-23 8:48 a.m., Mark Rutland wrote: On Mon, Jan 21, 2019 at 11:30:02AM +0530, Pramod Kumar wrote:

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Sudeep Holla
On Wed, Jan 23, 2019 at 09:05:26AM -0800, Scott Branden wrote: > Hi Mark, > > Hopefully I can shed some light on the use case inline. > > On 2019-01-23 8:48 a.m., Mark Rutland wrote: > > On Mon, Jan 21, 2019 at 11:30:02AM +0530, Pramod Kumar wrote: > > > On Mon, Jan 21, 2019 at 11:28 AM Pramod

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Scott Branden
Hi Mark, Hopefully I can shed some light on the use case inline. On 2019-01-23 8:48 a.m., Mark Rutland wrote: On Mon, Jan 21, 2019 at 11:30:02AM +0530, Pramod Kumar wrote: On Mon, Jan 21, 2019 at 11:28 AM Pramod Kumar wrote: Need comes from a specific use case where one Accelerator

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Mark Rutland
On Fri, Jan 18, 2019 at 11:16:20AM +0530, Pramod Kumar wrote: > If CPU hotplug is supported, ipi_cpu_stop should use PSCI cpudie > call to stop the CPU. This call ensures L1/L2 cache flush, > CPUs cache-cohenrecy setting w.r.to interconnect. > > Apart from this, this gives control to f/w to

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Mark Rutland
On Mon, Jan 21, 2019 at 11:30:02AM +0530, Pramod Kumar wrote: > On Mon, Jan 21, 2019 at 11:28 AM Pramod Kumar > wrote: > > Need comes from a specific use case where one Accelerator card(SoC) is > plugged in a sever over a PCIe interface. This Card gets supply from a > battery, which

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-23 Thread Sudeep Holla
On Wed, Jan 23, 2019 at 10:21:05AM +0530, Pramod Kumar wrote: > Thanks Sudeep for reviewing. Please see my comment inline below. > > On Mon, Jan 21, 2019 at 4:52 PM Sudeep Holla wrote: [...] > > > > OK, but I was expecting the complete call path for this use-case. > > OK. Once power loss

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-22 Thread Pramod Kumar
Thanks Sudeep for reviewing. Please see my comment inline below. On Mon, Jan 21, 2019 at 4:52 PM Sudeep Holla wrote: > > On Mon, Jan 21, 2019 at 11:28:27AM +0530, Pramod Kumar wrote: > > On Fri, Jan 18, 2019 at 5:02 PM Sudeep Holla wrote: > > > On Fri, Jan 18, 2019 at 11:16:20AM +0530, Pramod

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-21 Thread Sudeep Holla
On Mon, Jan 21, 2019 at 11:28:27AM +0530, Pramod Kumar wrote: > On Fri, Jan 18, 2019 at 5:02 PM Sudeep Holla wrote: > > On Fri, Jan 18, 2019 at 11:16:20AM +0530, Pramod Kumar wrote: > > > If CPU hotplug is supported, ipi_cpu_stop should use PSCI cpudie > > > call to stop the CPU. This call

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-21 Thread Pramod Kumar
On Mon, Jan 21, 2019 at 11:30 AM Pramod Kumar wrote: > > > > On Mon, Jan 21, 2019 at 11:28 AM Pramod Kumar > wrote: >> >> Hi Sudeep, >> >> Thanks for having a glance on the patch. Please see my reply in line. >> >> Regards, >> Pramod >> >> On Fri, Jan 18, 2019 at 5:02 PM Sudeep Holla wrote:

Re: [PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-18 Thread Sudeep Holla
On Fri, Jan 18, 2019 at 11:16:20AM +0530, Pramod Kumar wrote: > If CPU hotplug is supported, ipi_cpu_stop should use PSCI cpudie > call to stop the CPU. This call ensures L1/L2 cache flush, > CPUs cache-cohenrecy setting w.r.to interconnect. > Firstly, this is not specific to PSCI and I don't see

[PATCH RFC 1/1] arm64: Use PSCI calls for CPU stop when hotplug is supported

2019-01-17 Thread Pramod Kumar
If CPU hotplug is supported, ipi_cpu_stop should use PSCI cpudie call to stop the CPU. This call ensures L1/L2 cache flush, CPUs cache-cohenrecy setting w.r.to interconnect. Apart from this, this gives control to f/w to reduce power consumption by take appropriate decesion on power rails for