Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Rafał Miłecki
On 18 June 2016 at 23:58, Rafał Miłecki wrote: > On 18 June 2016 at 21:26, Arend van Spriel > wrote: >> On 18-06-16 20:18, Rafał Miłecki wrote: >>> So far when receiving event about in-firmware-interface removal we were >>> notifying our listener

Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Rafał Miłecki
On 18 June 2016 at 23:58, Rafał Miłecki wrote: > On 18 June 2016 at 21:26, Arend van Spriel > wrote: >> On 18-06-16 20:18, Rafał Miłecki wrote: >>> So far when receiving event about in-firmware-interface removal we were >>> notifying our listener and afterwards we were removing Linux interface.

Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Rafał Miłecki
On 18 June 2016 at 21:26, Arend van Spriel wrote: > On 18-06-16 20:18, Rafał Miłecki wrote: >> So far when receiving event about in-firmware-interface removal we were >> notifying our listener and afterwards we were removing Linux interface. >> > > [snip] > >> >>

Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Rafał Miłecki
On 18 June 2016 at 21:26, Arend van Spriel wrote: > On 18-06-16 20:18, Rafał Miłecki wrote: >> So far when receiving event about in-firmware-interface removal we were >> notifying our listener and afterwards we were removing Linux interface. >> > > [snip] > >> >> diff --git

Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Arend van Spriel
On 18-06-16 20:18, Rafał Miłecki wrote: > So far when receiving event about in-firmware-interface removal we were > notifying our listener and afterwards we were removing Linux interface. > [snip] > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c >

Re: [PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Arend van Spriel
On 18-06-16 20:18, Rafał Miłecki wrote: > So far when receiving event about in-firmware-interface removal we were > notifying our listener and afterwards we were removing Linux interface. > [snip] > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c >

[PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Rafał Miłecki
So far when receiving event about in-firmware-interface removal we were notifying our listener and afterwards we were removing Linux interface. This order was most likely a try to avoid a lockup. Removing in-firmware interface could be requested by a driver code holding rtnl lock. Such code waits

[PATCH RFC 1/2] brcmfmac: remove interface before notifying listener

2016-06-18 Thread Rafał Miłecki
So far when receiving event about in-firmware-interface removal we were notifying our listener and afterwards we were removing Linux interface. This order was most likely a try to avoid a lockup. Removing in-firmware interface could be requested by a driver code holding rtnl lock. Such code waits