Re: [PATCH RFC 1/2] mm/swap.c: split put_compound_page function

2014-04-28 Thread Khalid Aziz
On 04/27/2014 07:35 AM, Jianyu Zhan wrote: Currently, put_compound_page should carefully handle tricky case to avoid racing with compound page releasing or spliting, which makes it growing quite lenthy(about 200+ lines) and need deep tab indention, which makes it quite hard to follow and maintain

Re: [PATCH RFC 1/2] mm/swap.c: split put_compound_page function

2014-04-28 Thread Jianyu Zhan
On Mon, Apr 28, 2014 at 11:00 PM, Michal Hocko wrote: > This is a big change and really hard to review to be honest. Maybe a > split up would make it easier to follow. Ok, actually it is quite simple, but the diff looks messy, I will try to split up this patch to several phases. Thanks, Jianyu

Re: [PATCH RFC 1/2] mm/swap.c: split put_compound_page function

2014-04-28 Thread Michal Hocko
On Sun 27-04-14 21:35:50, Jianyu Zhan wrote: > Currently, put_compound_page should carefully handle tricky case > to avoid racing with compound page releasing or spliting, which > makes it growing quite lenthy(about 200+ lines) and need deep > tab indention, which makes it quite hard to follow and

[PATCH RFC 1/2] mm/swap.c: split put_compound_page function

2014-04-27 Thread Jianyu Zhan
Currently, put_compound_page should carefully handle tricky case to avoid racing with compound page releasing or spliting, which makes it growing quite lenthy(about 200+ lines) and need deep tab indention, which makes it quite hard to follow and maintain. This patch tries to refactor this function