Re: [Xen-devel] [PATCH RFC 1/4] xen-gnt: prevent adding duplicate gnt callbacks

2013-07-11 Thread Roger Pau Monné
On 11/07/13 15:17, David Vrabel wrote: > On 08/07/13 14:03, Roger Pau Monne wrote: >> With the current implementation, the callback in the tail of the list >> can be added twice, because the check done in >> gnttab_request_free_callback is bogus, callback->next can be NULL if >> it is the last call

Re: [Xen-devel] [PATCH RFC 1/4] xen-gnt: prevent adding duplicate gnt callbacks

2013-07-11 Thread David Vrabel
On 08/07/13 14:03, Roger Pau Monne wrote: > With the current implementation, the callback in the tail of the list > can be added twice, because the check done in > gnttab_request_free_callback is bogus, callback->next can be NULL if > it is the last callback in the list. If we add the same callback

[PATCH RFC 1/4] xen-gnt: prevent adding duplicate gnt callbacks

2013-07-08 Thread Roger Pau Monne
With the current implementation, the callback in the tail of the list can be added twice, because the check done in gnttab_request_free_callback is bogus, callback->next can be NULL if it is the last callback in the list. If we add the same callback twice we end up with an infinite loop, were callb