Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-18 Thread Dave Chinner
On Sun, Feb 17, 2013 at 05:25:43PM -0800, Eric W. Biederman wrote: > Dave Chinner writes: > > > On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: > > > >> The crazy thing is that is that xfs appears to > >> directly write their incore inode structure into their journal. > > > >

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-18 Thread Dave Chinner
On Sun, Feb 17, 2013 at 05:25:43PM -0800, Eric W. Biederman wrote: Dave Chinner da...@fromorbit.com writes: On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: The crazy thing is that is that xfs appears to directly write their incore inode structure into their journal.

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-17 Thread Eric W. Biederman
Dave Chinner writes: > On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: > >> The crazy thing is that is that xfs appears to >> directly write their incore inode structure into their journal. > > Off topic, but it's actually a very sane thing to do. It's called > logical object

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-17 Thread Eric W. Biederman
Dave Chinner da...@fromorbit.com writes: On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: The crazy thing is that is that xfs appears to directly write their incore inode structure into their journal. Off topic, but it's actually a very sane thing to do. It's called

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-13 Thread Dave Chinner
On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: > Joel Becker writes: > > > On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: > >> > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > >> > index 2778258..3656b88 100644 > >> > --- a/fs/xfs/xfs_inode.c > >> > +++

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-13 Thread Eric W. Biederman
Joel Becker writes: > On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: >> > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c >> > index 2778258..3656b88 100644 >> > --- a/fs/xfs/xfs_inode.c >> > +++ b/fs/xfs/xfs_inode.c >> > @@ -570,11 +570,12 @@ xfs_dinode_from_disk( >> >

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-13 Thread Eric W. Biederman
Joel Becker jl...@evilplan.org writes: On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 2778258..3656b88 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -570,11 +570,12 @@ xfs_dinode_from_disk(

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2013-02-13 Thread Dave Chinner
On Wed, Feb 13, 2013 at 10:13:16AM -0800, Eric W. Biederman wrote: Joel Becker jl...@evilplan.org writes: On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 2778258..3656b88 100644 --- a/fs/xfs/xfs_inode.c +++

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-21 Thread Joel Becker
On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > > index 2778258..3656b88 100644 > > --- a/fs/xfs/xfs_inode.c > > +++ b/fs/xfs/xfs_inode.c > > @@ -570,11 +570,12 @@ xfs_dinode_from_disk( > > to->di_version = from

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-21 Thread Joel Becker
On Wed, Nov 21, 2012 at 10:55:24AM +1100, Dave Chinner wrote: diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 2778258..3656b88 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -570,11 +570,12 @@ xfs_dinode_from_disk( to-di_version = from -di_version;

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-20 Thread Dave Chinner
On Tue, Nov 20, 2012 at 04:43:38AM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > - Modify the incore inode to use kuid_t, kgid_t and kprojid_t. > - Remove xfs_get_projid and xfs_set_projid with projid being stored > in a single field they are unnecessary. > - Add dq_id (a

[PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-20 Thread Eric W. Biederman
From: "Eric W. Biederman" - Modify the incore inode to use kuid_t, kgid_t and kprojid_t. - Remove xfs_get_projid and xfs_set_projid with projid being stored in a single field they are unnecessary. - Add dq_id (a struct kqid) to struct xfs_dquot to retain the incore version of the quota

[PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-20 Thread Eric W. Biederman
From: Eric W. Biederman ebied...@xmission.com - Modify the incore inode to use kuid_t, kgid_t and kprojid_t. - Remove xfs_get_projid and xfs_set_projid with projid being stored in a single field they are unnecessary. - Add dq_id (a struct kqid) to struct xfs_dquot to retain the incore version

Re: [PATCH RFC 10/12] userns: Convert xfs to use kuid/kgid/kprojid where appropriate

2012-11-20 Thread Dave Chinner
On Tue, Nov 20, 2012 at 04:43:38AM -0800, Eric W. Biederman wrote: From: Eric W. Biederman ebied...@xmission.com - Modify the incore inode to use kuid_t, kgid_t and kprojid_t. - Remove xfs_get_projid and xfs_set_projid with projid being stored in a single field they are unnecessary. - Add