Re: [PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-05-01 Thread Tadeusz Struk
On 05/01/2015 09:21 AM, David Howells wrote: >> +.verify = RSA_verify_signature, >> > + .capabilities = PKEY_CAN_VERIFY, > Can we keep .verify_signature as the name of the first. The second is > redundant given the function pointers. I'm thinking that .verify

Re: [PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-05-01 Thread David Howells
Tadeusz Struk wrote: > +Additionally public key algorithm names are defined: > +#define PKEY_ALGO_DSA "dsa" > +#define PKEY_ALGO_RSA "rsa" > +These will be used to allocate public key tfm instances. These should be a blank line either side of the two #defines and the #defines should be indented

Re: [PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-05-01 Thread David Howells
Tadeusz Struk tadeusz.st...@intel.com wrote: +Additionally public key algorithm names are defined: +#define PKEY_ALGO_DSA dsa +#define PKEY_ALGO_RSA rsa +These will be used to allocate public key tfm instances. These should be a blank line either side of the two #defines and the #defines

Re: [PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-05-01 Thread Tadeusz Struk
On 05/01/2015 09:21 AM, David Howells wrote: +.verify = RSA_verify_signature, + .capabilities = PKEY_CAN_VERIFY, Can we keep .verify_signature as the name of the first. The second is redundant given the function pointers. I'm thinking that .verify will

[PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-04-30 Thread Tadeusz Struk
Change the existing rsa and public key code to integrate it with the new Public Key Encryption API. Signed-off-by: Tadeusz Struk --- Documentation/crypto/asymmetric-keys.txt | 10 +++- crypto/asymmetric_keys/Kconfig|1 crypto/asymmetric_keys/pkcs7_parser.c |4 +-

[PATCH RFC 2/2] crypto: RSA: KEYS: convert rsa and public key to new PKE API

2015-04-30 Thread Tadeusz Struk
Change the existing rsa and public key code to integrate it with the new Public Key Encryption API. Signed-off-by: Tadeusz Struk tadeusz.st...@intel.com --- Documentation/crypto/asymmetric-keys.txt | 10 +++- crypto/asymmetric_keys/Kconfig|1