Re: [PATCH RFC 2/2] tracing/block: add request operation and flags into trace events

2020-05-04 Thread Steven Rostedt
On Mon, 04 May 2020 18:16:21 +0300 Konstantin Khlebnikov wrote: > +/* Request operations, see enum req_opf */ > + > +TRACE_DEFINE_ENUM(REQ_OP_READ); > +TRACE_DEFINE_ENUM(REQ_OP_WRITE); > +TRACE_DEFINE_ENUM(REQ_OP_FLUSH); > +TRACE_DEFINE_ENUM(REQ_OP_DISCARD); > +TRACE_DEFINE_ENUM(REQ_OP_SECURE_ERA

[PATCH RFC 2/2] tracing/block: add request operation and flags into trace events

2020-05-04 Thread Konstantin Khlebnikov
It's hard to fit all flags into field 'rwbs' and even harder to remove something without breaking compatibility. Let's expose all request flags using common trace event methods: __print_symbolic and __print_flags. This adds 32-bit 'req' field printed as req=OP,FLAGS,... by all events. Exact consta