Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-19 Thread Ulf Hansson
On 9 November 2018 at 06:27, Kishon Vijay Abraham I wrote: > Hi Arnd, > > On 06/11/18 6:21 PM, Arnd Bergmann wrote: >> On 11/5/18, Kishon Vijay Abraham I wrote: >>> On 05/11/18 8:46 AM, Chunyan Zhang wrote: + sdhci_switch_extdma(host, true); >>> >>> A number of devices using

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-19 Thread Ulf Hansson
On 9 November 2018 at 06:27, Kishon Vijay Abraham I wrote: > Hi Arnd, > > On 06/11/18 6:21 PM, Arnd Bergmann wrote: >> On 11/5/18, Kishon Vijay Abraham I wrote: >>> On 05/11/18 8:46 AM, Chunyan Zhang wrote: + sdhci_switch_extdma(host, true); >>> >>> A number of devices using

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-08 Thread Kishon Vijay Abraham I
Hi Arnd, On 06/11/18 6:21 PM, Arnd Bergmann wrote: > On 11/5/18, Kishon Vijay Abraham I wrote: >> On 05/11/18 8:46 AM, Chunyan Zhang wrote: >>> >>> + sdhci_switch_extdma(host, true); >> >> A number of devices using sdhci-omap supports ADMA. So switching to >> external >> DMA shouldn't be

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-08 Thread Kishon Vijay Abraham I
Hi Arnd, On 06/11/18 6:21 PM, Arnd Bergmann wrote: > On 11/5/18, Kishon Vijay Abraham I wrote: >> On 05/11/18 8:46 AM, Chunyan Zhang wrote: >>> >>> + sdhci_switch_extdma(host, true); >> >> A number of devices using sdhci-omap supports ADMA. So switching to >> external >> DMA shouldn't be

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-06 Thread Chunyan Zhang
On Tue, 6 Nov 2018 at 20:51, Arnd Bergmann wrote: > > On 11/5/18, Kishon Vijay Abraham I wrote: > > On 05/11/18 8:46 AM, Chunyan Zhang wrote: > >> > >> +sdhci_switch_extdma(host, true); > > > > A number of devices using sdhci-omap supports ADMA. So switching to > > external > > DMA shouldn't

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-06 Thread Chunyan Zhang
On Tue, 6 Nov 2018 at 20:51, Arnd Bergmann wrote: > > On 11/5/18, Kishon Vijay Abraham I wrote: > > On 05/11/18 8:46 AM, Chunyan Zhang wrote: > >> > >> +sdhci_switch_extdma(host, true); > > > > A number of devices using sdhci-omap supports ADMA. So switching to > > external > > DMA shouldn't

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-06 Thread Arnd Bergmann
On 11/5/18, Kishon Vijay Abraham I wrote: > On 05/11/18 8:46 AM, Chunyan Zhang wrote: >> >> +sdhci_switch_extdma(host, true); > > A number of devices using sdhci-omap supports ADMA. So switching to > external > DMA shouldn't be unconditional. > > IMHO sdhci.c should see if the device supports

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-06 Thread Arnd Bergmann
On 11/5/18, Kishon Vijay Abraham I wrote: > On 05/11/18 8:46 AM, Chunyan Zhang wrote: >> >> +sdhci_switch_extdma(host, true); > > A number of devices using sdhci-omap supports ADMA. So switching to > external > DMA shouldn't be unconditional. > > IMHO sdhci.c should see if the device supports

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-04 Thread Kishon Vijay Abraham I
Hi, On 05/11/18 8:46 AM, Chunyan Zhang wrote: > sdhci-omap can support both external dma controllers via dmaengine > framework as well as ADMA in which the controller acts as DMA master. > > Signed-off-by: Chunyan Zhang > --- > drivers/mmc/host/sdhci-omap.c | 7 +++ > 1 file changed, 7

Re: [PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-04 Thread Kishon Vijay Abraham I
Hi, On 05/11/18 8:46 AM, Chunyan Zhang wrote: > sdhci-omap can support both external dma controllers via dmaengine > framework as well as ADMA in which the controller acts as DMA master. > > Signed-off-by: Chunyan Zhang > --- > drivers/mmc/host/sdhci-omap.c | 7 +++ > 1 file changed, 7

[PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-04 Thread Chunyan Zhang
sdhci-omap can support both external dma controllers via dmaengine framework as well as ADMA in which the controller acts as DMA master. Signed-off-by: Chunyan Zhang --- drivers/mmc/host/sdhci-omap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/mmc/host/sdhci-omap.c

[PATCH RFC 2/3] mmc: sdhci-omap: Add using external dma

2018-11-04 Thread Chunyan Zhang
sdhci-omap can support both external dma controllers via dmaengine framework as well as ADMA in which the controller acts as DMA master. Signed-off-by: Chunyan Zhang --- drivers/mmc/host/sdhci-omap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/mmc/host/sdhci-omap.c