Re: [PATCH RFC clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-01-06 Thread Rik van Riel
On Wed, 2021-01-06 at 11:53 -0800, Paul E. McKenney wrote: > On Wed, Jan 06, 2021 at 11:28:00AM -0500, Rik van Riel wrote: > > > + wdagain_nsec = clocksource_cyc2ns(delta, watchdog- > > > mult, watchdog->shift); > > + if (wdagain_nsec < 0 || wdagain_nsec > > >

Re: [PATCH RFC clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 11:28:00AM -0500, Rik van Riel wrote: > On Tue, 2021-01-05 at 16:41 -0800, paul...@kernel.org wrote: > > > > @@ -203,7 +204,6 @@ static void > > clocksource_watchdog_inject_delay(void) > > injectfail = inject_delay_run; > > if (!(++injectfail /

Re: [PATCH RFC clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-01-06 Thread Rik van Riel
On Tue, 2021-01-05 at 16:41 -0800, paul...@kernel.org wrote: > > @@ -203,7 +204,6 @@ static void > clocksource_watchdog_inject_delay(void) > injectfail = inject_delay_run; > if (!(++injectfail / inject_delay_run % inject_delay_freq)) { > printk("%s(): Injecting

[PATCH RFC clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-01-05 Thread paulmck
From: "Paul E. McKenney" When the clocksource watchdog marks a clock as unstable, this might be due to that clock being unstable or it might be due to delays that happen to occur between the reads of the two clocks. Yes, interrupts are disabled across those two reads, but there are no shortage