On Tue, 25 Aug 2020 10:13:59 +0200
Matthias Schiffer wrote:
> On Tue, 2020-07-28 at 17:05 +0200, Marek Behún wrote:
> > Hi,
> >
> > this is v4 of my RFC adding support for LEDs connected to Marvell
> > PHYs.
> >
> > Please note that if you want to test this, you still need to first
> > apply
>
Hi!
> > > The phydev name is not particularly nice:
> > >
> > > !mdio-mux!mdio@1!switch@0!mdio:00
...
> > > 400d.ethernet-1:00
> > > 400d.ethernet-1:01
> > > fixed-0:00
> >
> > Not nice, I see. In particular, it contains ":"... which would be a
> > problem.
> >
> > > The interface name
> > > You could make a good guess at matching to two together, but it is
> > > error prone. Phys are low level things which the user is not really
> > > involved in. They interact with interface names. ethtool, ip, etc, all
> > > use interface names. In fact, i don't know of any tool which uses
> >
On Sun, Aug 30, 2020 at 12:43:51AM +0200, Pavel Machek wrote:
> Hi!
>
> > > > And no, I don't want phydev name there.
> > >
> > > Ummm. Can we get little more explanation on that? I fear that LED
> > > device renaming will be tricky and phydev would work around that
> > > nicely.
> >
> > Hi Pave
Hi!
> > > And no, I don't want phydev name there.
> >
> > Ummm. Can we get little more explanation on that? I fear that LED
> > device renaming will be tricky and phydev would work around that
> > nicely.
>
> Hi Pavel
>
> The phydev name is not particularly nice:
>
> !mdio-mux!mdio@1!switch@0!
On Tue, 2020-07-28 at 17:05 +0200, Marek Behún wrote:
> Hi,
>
> this is v4 of my RFC adding support for LEDs connected to Marvell
> PHYs.
>
> Please note that if you want to test this, you still need to first
> apply
> the patch adding the LED private triggers support from Pavel's tree.
>
https:
> > And no, I don't want phydev name there.
>
> Ummm. Can we get little more explanation on that? I fear that LED
> device renaming will be tricky and phydev would work around that
> nicely.
Hi Pavel
The phydev name is not particularly nice:
!mdio-mux!mdio@1!switch@0!mdio:00
!mdio-mux!mdio@1!sw
Hi!
> this is v4 of my RFC adding support for LEDs connected to Marvell PHYs.
>
> Please note that if you want to test this, you still need to first apply
> the patch adding the LED private triggers support from Pavel's tree.
> https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/
On Tue, 28 Jul 2020 17:05:28 +0200 Marek Behún wrote:
> this is v4 of my RFC adding support for LEDs connected to Marvell PHYs.
FWIW a heads up for when you post a non-RFC version - neither patch
builds on allmodconfig right now.
Hi,
this is v4 of my RFC adding support for LEDs connected to Marvell PHYs.
Please note that if you want to test this, you still need to first apply
the patch adding the LED private triggers support from Pavel's tree.
https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=
10 matches
Mail list logo
