Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-15 Thread Tobias Waldekranz
On Thu, Apr 15, 2021 at 02:39, Vladimir Oltean wrote: > On Wed, Apr 14, 2021 at 08:39:53PM +0200, Tobias Waldekranz wrote: >> In order to have two entries for the same destination, they must belong >> to different FIDs. But that FID is also used for automatic learning. So >> if all ports use

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-14 Thread Vladimir Oltean
On Wed, Apr 14, 2021 at 08:39:53PM +0200, Tobias Waldekranz wrote: > In order to have two entries for the same destination, they must belong > to different FIDs. But that FID is also used for automatic learning. So > if all ports use their own FID, all the switched traffic will have to be >

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-14 Thread Tobias Waldekranz
On Wed, Apr 14, 2021 at 17:14, Marek Behun wrote: > On Tue, 13 Apr 2021 20:16:24 +0200 > Tobias Waldekranz wrote: > >> You could imagine a different mode in which the DSA driver would receive >> the bucket allocation from the bond/team driver (which in turn could >> come all the way from

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-14 Thread Marek Behun
On Tue, 13 Apr 2021 20:16:24 +0200 Tobias Waldekranz wrote: > You could imagine a different mode in which the DSA driver would receive > the bucket allocation from the bond/team driver (which in turn could > come all the way from userspace). Userspace could then implement > whatever strategy it

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-13 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 17:14, Marek Behun wrote: > On Tue, 13 Apr 2021 16:46:32 +0200 > Tobias Waldekranz wrote: > >> On Tue, Apr 13, 2021 at 02:27, Marek Behun wrote: >> > On Tue, 13 Apr 2021 01:54:50 +0200 >> > Marek Behun wrote: >> > >> >> I will look into this, maybe ask some follow-up

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-13 Thread Marek Behun
On Tue, 13 Apr 2021 16:46:32 +0200 Tobias Waldekranz wrote: > On Tue, Apr 13, 2021 at 02:27, Marek Behun wrote: > > On Tue, 13 Apr 2021 01:54:50 +0200 > > Marek Behun wrote: > > > >> I will look into this, maybe ask some follow-up questions. > > > > Tobias, > > > > it seems that currently

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-13 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 02:27, Marek Behun wrote: > On Tue, 13 Apr 2021 01:54:50 +0200 > Marek Behun wrote: > >> I will look into this, maybe ask some follow-up questions. > > Tobias, > > it seems that currently the LAGs in mv88e6xxx driver do not use the > HashTrunk feature (which can be

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-13 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 01:54, Marek Behun wrote: > On Tue, 13 Apr 2021 01:13:53 +0200 > Tobias Waldekranz wrote: > >> > ...you could get the isolation in place. But you will still lookup the >> > DA in the ATU, and there you will find a destination of either cpu0 or >> > cpu1. So for one of the

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Tue, 13 Apr 2021 02:27:30 +0200 Marek Behun wrote: > On Tue, 13 Apr 2021 01:54:50 +0200 > Marek Behun wrote: > > > I will look into this, maybe ask some follow-up questions. > > Tobias, > > it seems that currently the LAGs in mv88e6xxx driver do not use the > HashTrunk feature (which can

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Tue, 13 Apr 2021 01:54:50 +0200 Marek Behun wrote: > I will look into this, maybe ask some follow-up questions. Tobias, it seems that currently the LAGs in mv88e6xxx driver do not use the HashTrunk feature (which can be enabled via bit 11 of the MV88E6XXX_G2_TRUNK_MAPPING register). If we

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Tue, 13 Apr 2021 01:13:53 +0200 Tobias Waldekranz wrote: > > ...you could get the isolation in place. But you will still lookup the > > DA in the ATU, and there you will find a destination of either cpu0 or > > cpu1. So for one of the ports, the destination will be outside of its > > port

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 01:09, Tobias Waldekranz wrote: > On Tue, Apr 13, 2021 at 00:55, Marek Behun wrote: >> On Tue, 13 Apr 2021 00:05:51 +0200 >> Tobias Waldekranz wrote: >> >>> On Mon, Apr 12, 2021 at 23:50, Marek Behun wrote: >>> > On Mon, 12 Apr 2021 23:22:45 +0200 >>> > Tobias

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 00:55, Marek Behun wrote: > On Tue, 13 Apr 2021 00:05:51 +0200 > Tobias Waldekranz wrote: > >> On Mon, Apr 12, 2021 at 23:50, Marek Behun wrote: >> > On Mon, 12 Apr 2021 23:22:45 +0200 >> > Tobias Waldekranz wrote: >> > >> >> On Mon, Apr 12, 2021 at 21:30, Marek Behun

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Tue, 13 Apr 2021 01:48:05 +0300 Vladimir Oltean wrote: > On Tue, Apr 13, 2021 at 12:26:52AM +0200, Tobias Waldekranz wrote: > > On Tue, Apr 13, 2021 at 01:06, Vladimir Oltean wrote: > > > On Mon, Apr 12, 2021 at 11:49:22PM +0200, Tobias Waldekranz wrote: > > >> On Tue, Apr 13, 2021 at

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Tue, 13 Apr 2021 00:05:51 +0200 Tobias Waldekranz wrote: > On Mon, Apr 12, 2021 at 23:50, Marek Behun wrote: > > On Mon, 12 Apr 2021 23:22:45 +0200 > > Tobias Waldekranz wrote: > > > >> On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: > >> > On Mon, 12 Apr 2021 14:46:11 +0200 > >> >

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Vladimir Oltean
On Tue, Apr 13, 2021 at 12:26:52AM +0200, Tobias Waldekranz wrote: > On Tue, Apr 13, 2021 at 01:06, Vladimir Oltean wrote: > > On Mon, Apr 12, 2021 at 11:49:22PM +0200, Tobias Waldekranz wrote: > >> On Tue, Apr 13, 2021 at 00:34, Vladimir Oltean wrote: > >> > On Mon, Apr 12, 2021 at 11:22:45PM

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Tue, 13 Apr 2021 01:17:21 +0300 Vladimir Oltean wrote: > On Tue, Apr 13, 2021 at 12:04:57AM +0200, Marek Behun wrote: > > On Mon, 12 Apr 2021 19:32:11 +0300 > > Vladimir Oltean wrote: > > > > > On Mon, Apr 12, 2021 at 11:00:45PM +0800, DENG Qingfang wrote: > > > > On Sun, Apr 11, 2021 at

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 01:06, Vladimir Oltean wrote: > On Mon, Apr 12, 2021 at 11:49:22PM +0200, Tobias Waldekranz wrote: >> On Tue, Apr 13, 2021 at 00:34, Vladimir Oltean wrote: >> > On Mon, Apr 12, 2021 at 11:22:45PM +0200, Tobias Waldekranz wrote: >> >> On Mon, Apr 12, 2021 at 21:30, Marek

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Vladimir Oltean
On Tue, Apr 13, 2021 at 12:04:57AM +0200, Marek Behun wrote: > On Mon, 12 Apr 2021 19:32:11 +0300 > Vladimir Oltean wrote: > > > On Mon, Apr 12, 2021 at 11:00:45PM +0800, DENG Qingfang wrote: > > > On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > > > > > > > > So I'd be tempted

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Vladimir Oltean
On Mon, Apr 12, 2021 at 11:49:22PM +0200, Tobias Waldekranz wrote: > On Tue, Apr 13, 2021 at 00:34, Vladimir Oltean wrote: > > On Mon, Apr 12, 2021 at 11:22:45PM +0200, Tobias Waldekranz wrote: > >> On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: > >> > On Mon, 12 Apr 2021 14:46:11 +0200 > >>

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Mon, Apr 12, 2021 at 23:50, Marek Behun wrote: > On Mon, 12 Apr 2021 23:22:45 +0200 > Tobias Waldekranz wrote: > >> On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: >> > On Mon, 12 Apr 2021 14:46:11 +0200 >> > Tobias Waldekranz wrote: >> > >> >> I agree. Unless you only have a few really

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Mon, 12 Apr 2021 19:32:11 +0300 Vladimir Oltean wrote: > On Mon, Apr 12, 2021 at 11:00:45PM +0800, DENG Qingfang wrote: > > On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > > > > > > So I'd be tempted to say 'tough luck' if all your ports are not up, and > > > the ones

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Mon, 12 Apr 2021 23:49:22 +0200 Tobias Waldekranz wrote: > On Tue, Apr 13, 2021 at 00:34, Vladimir Oltean wrote: > > On Mon, Apr 12, 2021 at 11:22:45PM +0200, Tobias Waldekranz wrote: > >> On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: > >> > On Mon, 12 Apr 2021 14:46:11 +0200 > >> >

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Mon, 12 Apr 2021 23:22:45 +0200 Tobias Waldekranz wrote: > On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: > > On Mon, 12 Apr 2021 14:46:11 +0200 > > Tobias Waldekranz wrote: > > > >> I agree. Unless you only have a few really wideband flows, a LAG will > >> typically do a great job

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Tue, Apr 13, 2021 at 00:34, Vladimir Oltean wrote: > On Mon, Apr 12, 2021 at 11:22:45PM +0200, Tobias Waldekranz wrote: >> On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: >> > On Mon, 12 Apr 2021 14:46:11 +0200 >> > Tobias Waldekranz wrote: >> > >> >> I agree. Unless you only have a few

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Vladimir Oltean
On Mon, Apr 12, 2021 at 11:22:45PM +0200, Tobias Waldekranz wrote: > On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: > > On Mon, 12 Apr 2021 14:46:11 +0200 > > Tobias Waldekranz wrote: > > > >> I agree. Unless you only have a few really wideband flows, a LAG will > >> typically do a great job

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Mon, Apr 12, 2021 at 21:30, Marek Behun wrote: > On Mon, 12 Apr 2021 14:46:11 +0200 > Tobias Waldekranz wrote: > >> I agree. Unless you only have a few really wideband flows, a LAG will >> typically do a great job with balancing. This will happen without the >> user having to do any

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Mon, Apr 12, 2021 at 17:35, Vladimir Oltean wrote: > On Mon, Apr 12, 2021 at 02:46:11PM +0200, Tobias Waldekranz wrote: >> On Sun, Apr 11, 2021 at 21:50, Vladimir Oltean wrote: >> > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >> >> On Sat, 10 Apr 2021 15:34:46 +0200 >> >>

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Marek Behun
On Mon, 12 Apr 2021 14:46:11 +0200 Tobias Waldekranz wrote: > I agree. Unless you only have a few really wideband flows, a LAG will > typically do a great job with balancing. This will happen without the > user having to do any configuration at all. It would also perform well > in

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Vladimir Oltean
On Mon, Apr 12, 2021 at 11:00:45PM +0800, DENG Qingfang wrote: > On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > > > > So I'd be tempted to say 'tough luck' if all your ports are not up, and > > the ones that are are assigned statically to the same CPU port. It's a > >

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread DENG Qingfang
On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > > So I'd be tempted to say 'tough luck' if all your ports are not up, and > the ones that are are assigned statically to the same CPU port. It's a > compromise between flexibility and simplicity, and I would go for > simplicity

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Vladimir Oltean
On Mon, Apr 12, 2021 at 02:46:11PM +0200, Tobias Waldekranz wrote: > On Sun, Apr 11, 2021 at 21:50, Vladimir Oltean wrote: > > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > >> On Sat, 10 Apr 2021 15:34:46 +0200 > >> Ansuel Smith wrote: > >> > >> > Hi, > >> > this is a respin of

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Tobias Waldekranz
On Sun, Apr 11, 2021 at 21:50, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >> On Sat, 10 Apr 2021 15:34:46 +0200 >> Ansuel Smith wrote: >> >> > Hi, >> > this is a respin of the Marek series in hope that this time we can >> > finally make some progress

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Ansuel Smith
On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > > On Sat, 10 Apr 2021 15:34:46 +0200 > > Ansuel Smith wrote: > > > > > Hi, > > > this is a respin of the Marek series in hope that this time we can > > > finally make

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-12 Thread Ansuel Smith
On Sun, Apr 11, 2021 at 08:39:12PM +0200, Andrew Lunn wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > > On Sat, 10 Apr 2021 15:34:46 +0200 > > Ansuel Smith wrote: > > > > > Hi, > > > this is a respin of the Marek series in hope that this time we can > > > finally make

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Florian Fainelli
On 4/11/2021 4:53 PM, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: >> On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >>> On Sat, 10 Apr 2021 15:34:46 +0200 >>> Ansuel Smith wrote: >>> Hi, this is a respin of the Marek series

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Florian Fainelli
On 4/11/2021 11:39 AM, Andrew Lunn wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >> On Sat, 10 Apr 2021 15:34:46 +0200 >> Ansuel Smith wrote: >> >>> Hi, >>> this is a respin of the Marek series in hope that this time we can >>> finally make some progress with dsa

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Vladimir Oltean
On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > > On Sat, 10 Apr 2021 15:34:46 +0200 > > Ansuel Smith wrote: > > > > > Hi, > > > this is a respin of the Marek series in hope that this time we can > > > finally make

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Vladimir Oltean
On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > On Sat, 10 Apr 2021 15:34:46 +0200 > Ansuel Smith wrote: > > > Hi, > > this is a respin of the Marek series in hope that this time we can > > finally make some progress with dsa supporting multi-cpu port. > > > > This implementation

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Andrew Lunn
On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > On Sat, 10 Apr 2021 15:34:46 +0200 > Ansuel Smith wrote: > > > Hi, > > this is a respin of the Marek series in hope that this time we can > > finally make some progress with dsa supporting multi-cpu port. > > > > This implementation

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Ansuel Smith
On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > On Sat, 10 Apr 2021 15:34:46 +0200 > Ansuel Smith wrote: > > > Hi, > > this is a respin of the Marek series in hope that this time we can > > finally make some progress with dsa supporting multi-cpu port. > > > > This implementation

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Marek Behun
On Sat, 10 Apr 2021 15:34:46 +0200 Ansuel Smith wrote: > Hi, > this is a respin of the Marek series in hope that this time we can > finally make some progress with dsa supporting multi-cpu port. > > This implementation is similar to the Marek series but with some tweaks. > This adds support for

[PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Ansuel Smith
Hi, this is a respin of the Marek series in hope that this time we can finally make some progress with dsa supporting multi-cpu port. This implementation is similar to the Marek series but with some tweaks. This adds support for multiple-cpu port but leave the driver the decision of the type of