Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-04-03 Thread Steven Rostedt
On Fri, 3 Apr 2015 11:29:04 +0200 (CEST) Miroslav Benes wrote: > Yes, this works but there is a slight difference to the previous behaviour > which I tried to preserve in my patch. ftrace_ops_get_func in your patch > does not check FTRACE_FORCE_LIST_FUNC. I do not know if that is a real >

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-04-03 Thread Miroslav Benes
On Thu, 2 Apr 2015, Steven Rostedt wrote: > On Thu, 2 Apr 2015 13:11:16 +0200 (CEST) > Miroslav Benes wrote: > > > On Thu, 5 Mar 2015, Steven Rostedt wrote: > > > > > On Thu, 5 Mar 2015 16:56:43 +0100 (CET) > > > Miroslav Benes wrote: > > > > > > > I don't know if you plan to do something

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-04-03 Thread Miroslav Benes
On Thu, 2 Apr 2015, Steven Rostedt wrote: On Thu, 2 Apr 2015 13:11:16 +0200 (CEST) Miroslav Benes mbe...@suse.cz wrote: On Thu, 5 Mar 2015, Steven Rostedt wrote: On Thu, 5 Mar 2015 16:56:43 +0100 (CET) Miroslav Benes mbe...@suse.cz wrote: I don't know if you plan to do

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-04-03 Thread Steven Rostedt
On Fri, 3 Apr 2015 11:29:04 +0200 (CEST) Miroslav Benes mbe...@suse.cz wrote: Yes, this works but there is a slight difference to the previous behaviour which I tried to preserve in my patch. ftrace_ops_get_func in your patch does not check FTRACE_FORCE_LIST_FUNC. I do not know if that is a

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-04-02 Thread Steven Rostedt
On Thu, 2 Apr 2015 13:11:16 +0200 (CEST) Miroslav Benes wrote: > On Thu, 5 Mar 2015, Steven Rostedt wrote: > > > On Thu, 5 Mar 2015 16:56:43 +0100 (CET) > > Miroslav Benes wrote: > > > > > I don't know if you plan to do something about this patch or if you just > > > missed it in your e-mail

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-04-02 Thread Miroslav Benes
On Thu, 5 Mar 2015, Steven Rostedt wrote: > On Thu, 5 Mar 2015 16:56:43 +0100 (CET) > Miroslav Benes wrote: > > > I don't know if you plan to do something about this patch or if you just > > missed it in your e-mail pile. Should I resend it or have you already > > scratched that? > > Thanks

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-04-02 Thread Steven Rostedt
On Thu, 2 Apr 2015 13:11:16 +0200 (CEST) Miroslav Benes mbe...@suse.cz wrote: On Thu, 5 Mar 2015, Steven Rostedt wrote: On Thu, 5 Mar 2015 16:56:43 +0100 (CET) Miroslav Benes mbe...@suse.cz wrote: I don't know if you plan to do something about this patch or if you just missed it

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-04-02 Thread Miroslav Benes
On Thu, 5 Mar 2015, Steven Rostedt wrote: On Thu, 5 Mar 2015 16:56:43 +0100 (CET) Miroslav Benes mbe...@suse.cz wrote: I don't know if you plan to do something about this patch or if you just missed it in your e-mail pile. Should I resend it or have you already scratched that?

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-03-05 Thread Miroslav Benes
On Thu, 5 Mar 2015, Steven Rostedt wrote: > On Thu, 5 Mar 2015 16:56:43 +0100 (CET) > Miroslav Benes wrote: > > > I don't know if you plan to do something about this patch or if you just > > missed it in your e-mail pile. Should I resend it or have you already > > scratched that? > > Thanks

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-03-05 Thread Steven Rostedt
On Thu, 5 Mar 2015 16:56:43 +0100 (CET) Miroslav Benes wrote: > I don't know if you plan to do something about this patch or if you just > missed it in your e-mail pile. Should I resend it or have you already > scratched that? Thanks for the reminder. It was marked as "todo" but fell in the

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-03-05 Thread Miroslav Benes
On Thu, 19 Feb 2015, Miroslav Benes wrote: > Dynamically allocated trampolines call ftrace_ops_get_func to get the > function which they should call. For dynamic fops (FTRACE_OPS_FL_DYNAMIC > flag is set) ftrace_ops_list_func is always returned. This is reasonable > for static trampolines but

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-03-05 Thread Steven Rostedt
On Thu, 5 Mar 2015 16:56:43 +0100 (CET) Miroslav Benes mbe...@suse.cz wrote: I don't know if you plan to do something about this patch or if you just missed it in your e-mail pile. Should I resend it or have you already scratched that? Thanks for the reminder. It was marked as todo but fell

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-03-05 Thread Miroslav Benes
On Thu, 5 Mar 2015, Steven Rostedt wrote: On Thu, 5 Mar 2015 16:56:43 +0100 (CET) Miroslav Benes mbe...@suse.cz wrote: I don't know if you plan to do something about this patch or if you just missed it in your e-mail pile. Should I resend it or have you already scratched that?

Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-03-05 Thread Miroslav Benes
On Thu, 19 Feb 2015, Miroslav Benes wrote: Dynamically allocated trampolines call ftrace_ops_get_func to get the function which they should call. For dynamic fops (FTRACE_OPS_FL_DYNAMIC flag is set) ftrace_ops_list_func is always returned. This is reasonable for static trampolines but goes

[PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops

2015-02-19 Thread Miroslav Benes
Dynamically allocated trampolines call ftrace_ops_get_func to get the function which they should call. For dynamic fops (FTRACE_OPS_FL_DYNAMIC flag is set) ftrace_ops_list_func is always returned. This is reasonable for static trampolines but goes against the main advantage of dynamic ones, that

[PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops-func even for dynamic fops

2015-02-19 Thread Miroslav Benes
Dynamically allocated trampolines call ftrace_ops_get_func to get the function which they should call. For dynamic fops (FTRACE_OPS_FL_DYNAMIC flag is set) ftrace_ops_list_func is always returned. This is reasonable for static trampolines but goes against the main advantage of dynamic ones, that