Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Vincenzo Frascino
On 11/16/20 1:50 PM, Andrey Konovalov wrote: > Fixing this sounds like a good idea, but perhaps not as a part of this > series, to not overinflate it even further. > > I've filed a bug for this: https://bugzilla.kernel.org/show_bug.cgi?id=210221 Fine by me. -- Regards, Vincenzo

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Andrey Konovalov
On Mon, Nov 16, 2020 at 1:42 PM Vincenzo Frascino wrote: > > > Not sure why we did this instead of the following, but okay. > > config KASAN_STACK > - int > - default 1 if KASAN_STACK_ENABLE || CC_IS_GCC > - default 0 > + bool >

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Vincenzo Frascino
On 11/16/20 12:19 PM, Dmitry Vyukov wrote: > On Mon, Nov 16, 2020 at 1:16 PM Catalin Marinas > wrote: >> >> On Mon, Nov 16, 2020 at 12:50:00PM +0100, Marco Elver wrote: >>> On Mon, 16 Nov 2020 at 11:59, Dmitry Vyukov wrote: On Thu, Oct 29, 2020 at 8:57 PM 'Andrey Konovalov' via

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Dmitry Vyukov
On Mon, Nov 16, 2020 at 1:16 PM Catalin Marinas wrote: > > On Mon, Nov 16, 2020 at 12:50:00PM +0100, Marco Elver wrote: > > On Mon, 16 Nov 2020 at 11:59, Dmitry Vyukov wrote: > > > On Thu, Oct 29, 2020 at 8:57 PM 'Andrey Konovalov' via kasan-dev > > > wrote: > > > > On Tue, Oct 27, 2020 at 1:44

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Catalin Marinas
On Mon, Nov 16, 2020 at 12:50:00PM +0100, Marco Elver wrote: > On Mon, 16 Nov 2020 at 11:59, Dmitry Vyukov wrote: > > On Thu, Oct 29, 2020 at 8:57 PM 'Andrey Konovalov' via kasan-dev > > wrote: > > > On Tue, Oct 27, 2020 at 1:44 PM Dmitry Vyukov wrote: > > > > > > > > On Thu, Oct 22, 2020 at

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Marco Elver
On Mon, 16 Nov 2020 at 11:59, Dmitry Vyukov wrote: > > On Thu, Oct 29, 2020 at 8:57 PM 'Andrey Konovalov' via kasan-dev > wrote: > > > > On Tue, Oct 27, 2020 at 1:44 PM Dmitry Vyukov wrote: > > > > > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov > > > wrote: > > > > > > > > There's a

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-11-16 Thread Dmitry Vyukov
On Thu, Oct 29, 2020 at 8:57 PM 'Andrey Konovalov' via kasan-dev wrote: > > On Tue, Oct 27, 2020 at 1:44 PM Dmitry Vyukov wrote: > > > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov > > wrote: > > > > > > There's a config option CONFIG_KASAN_STACK that has to be enabled for > > > KASAN to

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-10-29 Thread Andrey Konovalov
On Tue, Oct 27, 2020 at 1:44 PM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov > wrote: > > > > There's a config option CONFIG_KASAN_STACK that has to be enabled for > > KASAN to use stack instrumentation and perform validity checks for > > stack variables. > > > >

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-10-27 Thread Dmitry Vyukov
On Tue, Oct 27, 2020 at 1:44 PM Dmitry Vyukov wrote: > > On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov > wrote: > > > > There's a config option CONFIG_KASAN_STACK that has to be enabled for > > KASAN to use stack instrumentation and perform validity checks for > > stack variables. > > > >

Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-10-27 Thread Dmitry Vyukov
On Thu, Oct 22, 2020 at 3:19 PM Andrey Konovalov wrote: > > There's a config option CONFIG_KASAN_STACK that has to be enabled for > KASAN to use stack instrumentation and perform validity checks for > stack variables. > > There's no need to unpoison stack when CONFIG_KASAN_STACK is not enabled. >

[PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK

2020-10-22 Thread Andrey Konovalov
There's a config option CONFIG_KASAN_STACK that has to be enabled for KASAN to use stack instrumentation and perform validity checks for stack variables. There's no need to unpoison stack when CONFIG_KASAN_STACK is not enabled. Only call kasan_unpoison_task_stack[_below]() when CONFIG_KASAN_STACK