Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-05 Thread Can Guo
On 2021-01-05 15:33, Adrian Hunter wrote: On 5/01/21 9:28 am, Can Guo wrote: On 2021-01-05 15:16, Adrian Hunter wrote: On 4/01/21 8:55 pm, Bjorn Andersson wrote: On Mon 04 Jan 03:15 CST 2021, Adrian Hunter wrote: On 22/12/20 3:49 pm, Ziqi Chen wrote: As per specs, e.g, JESD220E chapter

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Adrian Hunter
On 5/01/21 9:28 am, Can Guo wrote: > On 2021-01-05 15:16, Adrian Hunter wrote: >> On 4/01/21 8:55 pm, Bjorn Andersson wrote: >>> On Mon 04 Jan 03:15 CST 2021, Adrian Hunter wrote: >>> On 22/12/20 3:49 pm, Ziqi Chen wrote: > As per specs, e.g, JESD220E chapter 7.2, while powering >

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Can Guo
On 2021-01-05 15:16, Adrian Hunter wrote: On 4/01/21 8:55 pm, Bjorn Andersson wrote: On Mon 04 Jan 03:15 CST 2021, Adrian Hunter wrote: On 22/12/20 3:49 pm, Ziqi Chen wrote: As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Adrian Hunter
On 4/01/21 8:55 pm, Bjorn Andersson wrote: > On Mon 04 Jan 03:15 CST 2021, Adrian Hunter wrote: > >> On 22/12/20 3:49 pm, Ziqi Chen wrote: >>> As per specs, e.g, JESD220E chapter 7.2, while powering >>> off/on the ufs device, RST_N signal and REF_CLK signal >>> should be between VSS(Ground) and

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Can Guo
On 2021-01-05 02:57, Bjorn Andersson wrote: On Mon 28 Dec 19:18 CST 2020, Can Guo wrote: On 2020-12-29 01:55, Bjorn Andersson wrote: > On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: > > > As per specs, e.g, JESD220E chapter 7.2, while powering > > off/on the ufs device, RST_N signal and

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Bjorn Andersson
On Mon 28 Dec 19:48 CST 2020, Can Guo wrote: > On 2020-12-29 09:18, Can Guo wrote: > > On 2020-12-29 01:55, Bjorn Andersson wrote: > > > On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: > > > > > > > As per specs, e.g, JESD220E chapter 7.2, while powering > > > > off/on the ufs device, RST_N

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Bjorn Andersson
On Mon 28 Dec 19:18 CST 2020, Can Guo wrote: > On 2020-12-29 01:55, Bjorn Andersson wrote: > > On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: > > > > > As per specs, e.g, JESD220E chapter 7.2, while powering > > > off/on the ufs device, RST_N signal and REF_CLK signal > > > should be between

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Bjorn Andersson
On Mon 04 Jan 03:15 CST 2021, Adrian Hunter wrote: > On 22/12/20 3:49 pm, Ziqi Chen wrote: > > As per specs, e.g, JESD220E chapter 7.2, while powering > > off/on the ufs device, RST_N signal and REF_CLK signal > > should be between VSS(Ground) and VCCQ/VCCQ2. > > > > To flexibly control device

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2021-01-04 Thread Adrian Hunter
On 22/12/20 3:49 pm, Ziqi Chen wrote: > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function >

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-28 Thread Can Guo
On 2020-12-29 09:18, Can Guo wrote: On 2020-12-29 01:55, Bjorn Andersson wrote: On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-28 Thread Can Guo
On 2020-12-29 01:55, Bjorn Andersson wrote: On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To flexibly control device reset line,

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-28 Thread Bjorn Andersson
On Tue 22 Dec 07:49 CST 2020, Ziqi Chen wrote: > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function >

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-24 Thread ziqichen
On 2020-12-24 04:45, Avri Altman wrote: Hi, As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To flexibly control device reset line, refactor the function ufschd_vops_device_reset(sturct

RE: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-23 Thread Avri Altman
Hi, > > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function > ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_ >

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-23 Thread Can Guo
On 2020-12-22 21:49, Ziqi Chen wrote: As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To flexibly control device reset line, refactor the function ufschd_vops_device_reset(sturct ufs_hba

Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-23 Thread Stanley Chu
On Tue, 2020-12-22 at 21:49 +0800, Ziqi Chen wrote: > As per specs, e.g, JESD220E chapter 7.2, while powering > off/on the ufs device, RST_N signal and REF_CLK signal > should be between VSS(Ground) and VCCQ/VCCQ2. > > To flexibly control device reset line, refactor the function >

[PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-22 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_N signal and REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. To flexibly control device reset line, refactor the function ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_