Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Sylwester Nawrocki
On 02/04/14 10:01, Peter De Schrijver wrote: > On Tue, Apr 01, 2014 at 03:19:40PM +0200, Ben Dooks wrote: >> On 31/03/14 21:06, Greg KH wrote: >>> On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Sylwester Nawrocki
On 02/04/14 07:37, Sascha Hauer wrote: > On Tue, Apr 01, 2014 at 09:37:44AM -0700, Greg KH wrote: >> On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: >>> On 01/04/14 15:19, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: >> On Mon, Mar 31, 2014 at 06:41:56PM +0200,

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Sylwester Nawrocki
On 01/04/14 18:37, Greg KH wrote: > On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: >> On 01/04/14 15:19, Ben Dooks wrote: >>> On 31/03/14 21:06, Greg KH wrote: > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: >> [...] > I don't understand why you

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Peter De Schrijver
On Tue, Apr 01, 2014 at 03:19:40PM +0200, Ben Dooks wrote: > On 31/03/14 21:06, Greg KH wrote: > > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: > >> This function adds a helper function to configure clock parents and rates > >> as specified in clock-parents, clock-rates DT

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Peter De Schrijver
On Tue, Apr 01, 2014 at 03:19:40PM +0200, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Sylwester Nawrocki
On 01/04/14 18:37, Greg KH wrote: On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: On 01/04/14 15:19, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: [...] I don't understand why you need the driver

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Sylwester Nawrocki
On 02/04/14 07:37, Sascha Hauer wrote: On Tue, Apr 01, 2014 at 09:37:44AM -0700, Greg KH wrote: On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: On 01/04/14 15:19, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-02 Thread Sylwester Nawrocki
On 02/04/14 10:01, Peter De Schrijver wrote: On Tue, Apr 01, 2014 at 03:19:40PM +0200, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sascha Hauer
On Tue, Apr 01, 2014 at 09:37:44AM -0700, Greg KH wrote: > On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: > > On 01/04/14 15:19, Ben Dooks wrote: > > > On 31/03/14 21:06, Greg KH wrote: > > >> > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: > > [...] > >

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: > On 01/04/14 15:19, Ben Dooks wrote: > > On 31/03/14 21:06, Greg KH wrote: > >> > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: > [...] > >> > I don't understand why you need the driver core to initialize

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 02:19:40PM +0100, Ben Dooks wrote: > On 31/03/14 21:06, Greg KH wrote: > >On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: > >>This function adds a helper function to configure clock parents and rates > >>as specified in clock-parents, clock-rates DT

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sylwester Nawrocki
Hi Laurent, On 01/04/14 15:15, Laurent Pinchart wrote: [...] >> +/** >> + * of_clk_device_init() - parse and set clk configuration assigned to a >> device >> + * @node: device node to apply the configuration for >> + * >> + * This function parses 'clock-parents' and 'clock-rates' properties and

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sylwester Nawrocki
On 01/04/14 15:19, Ben Dooks wrote: > On 31/03/14 21:06, Greg KH wrote: >> > On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: [...] >> > I don't understand why you need the driver core to initialize this one >> > type of thing? That should be in a driver, or in a class, or at

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Ben Dooks
On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Laurent Pinchart
Hi Sylwester, Thank you for the patch. On Monday 31 March 2014 18:41:56 Sylwester Nawrocki wrote: > This function adds a helper function to configure clock parents and rates > as specified in clock-parents, clock-rates DT properties for a consumer > device and a call to it before driver is bound

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sylwester Nawrocki
On 01/04/14 08:23, Sascha Hauer wrote: >> tree/bindings/clock/clock-bindings.txt >> > b/Documentation/devicetree/bindings/clock/clock-bindings.txt >>> > >index 700e7aa..59fbb4e 100644 >>> > >--- a/Documentation/devicetree/bindings/clock/clock-bindings.txt >>> > >+++

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sascha Hauer
On Mon, Mar 31, 2014 at 06:04:54PM +0100, Ben Dooks wrote: > On 31/03/14 17:41, Sylwester Nawrocki wrote: > >This function adds a helper function to configure clock parents and rates > >as specified in clock-parents, clock-rates DT properties for a consumer > >device and a call to it before driver

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sascha Hauer
On Mon, Mar 31, 2014 at 06:04:54PM +0100, Ben Dooks wrote: On 31/03/14 17:41, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sylwester Nawrocki
On 01/04/14 08:23, Sascha Hauer wrote: tree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt index 700e7aa..59fbb4e 100644 --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt +++

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Laurent Pinchart
Hi Sylwester, Thank you for the patch. On Monday 31 March 2014 18:41:56 Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound to

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Ben Dooks
On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sylwester Nawrocki
On 01/04/14 15:19, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: [...] I don't understand why you need the driver core to initialize this one type of thing? That should be in a driver, or in a class, or at worse

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sylwester Nawrocki
Hi Laurent, On 01/04/14 15:15, Laurent Pinchart wrote: [...] +/** + * of_clk_device_init() - parse and set clk configuration assigned to a device + * @node: device node to apply the configuration for + * + * This function parses 'clock-parents' and 'clock-rates' properties and sets + *

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 02:19:40PM +0100, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: On 01/04/14 15:19, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: [...] I don't understand why you need the driver core to initialize this one

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-04-01 Thread Sascha Hauer
On Tue, Apr 01, 2014 at 09:37:44AM -0700, Greg KH wrote: On Tue, Apr 01, 2014 at 04:23:12PM +0200, Sylwester Nawrocki wrote: On 01/04/14 15:19, Ben Dooks wrote: On 31/03/14 21:06, Greg KH wrote: On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: [...] I don't

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-03-31 Thread Greg KH
On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: > This function adds a helper function to configure clock parents and rates > as specified in clock-parents, clock-rates DT properties for a consumer > device and a call to it before driver is bound to a device. > >

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-03-31 Thread Ben Dooks
On 31/03/14 17:41, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound to a device. [snip]

[PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-03-31 Thread Sylwester Nawrocki
This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound to a device. Signed-off-by: Sylwester Nawrocki --- Changes since v3: - added detailed description of

[PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-03-31 Thread Sylwester Nawrocki
This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound to a device. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- Changes since v3: - added

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-03-31 Thread Ben Dooks
On 31/03/14 17:41, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound to a device. [snip]

Re: [PATCH RFC v4 2/2] clk: Add handling of clk parent and rate assigned from DT

2014-03-31 Thread Greg KH
On Mon, Mar 31, 2014 at 06:41:56PM +0200, Sylwester Nawrocki wrote: This function adds a helper function to configure clock parents and rates as specified in clock-parents, clock-rates DT properties for a consumer device and a call to it before driver is bound to a device. Signed-off-by: