Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > > From: James Bottomley > > > > > > Signed-off-by: James

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > > From: James Bottomley > > > > > > Signed-off-by: James Bottomley > > > > > > > I really think

Re: [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 09:47:54AM -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > From: James Bottomley > > > > Signed-off-by: James Bottomley > > > > I really

Re: [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 09:47:54AM -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > From: James Bottomley > > > > Signed-off-by: James Bottomley > > > > I really think we should not use the ugly read/write interface for any > new things. > >

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 03:45:58PM -0800, James Bottomley wrote: > Why don't you start by doubling the timeout? If nothing notices, > chances are nothing relies on this aspect of the interface and it can > be easily removed. Okay, fair enough, with a print I think it solves my concern. I sent a

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 03:45:58PM -0800, James Bottomley wrote: > Why don't you start by doubling the timeout? If nothing notices, > chances are nothing relies on this aspect of the interface and it can > be easily removed. Okay, fair enough, with a print I think it solves my concern. I sent a

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 16:30 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 03:20:12PM -0800, James Bottomley wrote: > > > > So you are saying there is so much already deployed TPM2 software > > > that has this TPM_DEVICE env var convention that we need to > > > support it with compat? >

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 16:30 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 03:20:12PM -0800, James Bottomley wrote: > > > > So you are saying there is so much already deployed TPM2 software > > > that has this TPM_DEVICE env var convention that we need to > > > support it with compat? >

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 03:20:12PM -0800, James Bottomley wrote: > > So you are saying there is so much already deployed TPM2 software > > that has this TPM_DEVICE env var convention that we need to support > > it with compat? > > > > I'm really surprised by that.. But OK. > > > > Can you at

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 03:20:12PM -0800, James Bottomley wrote: > > So you are saying there is so much already deployed TPM2 software > > that has this TPM_DEVICE env var convention that we need to support > > it with compat? > > > > I'm really surprised by that.. But OK. > > > > Can you at

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 16:04 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 02:57:11PM -0800, James Bottomley wrote: > > On Mon, 2017-01-23 at 15:49 -0700, Jason Gunthorpe wrote: > > > On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > > > > On Mon, 2017-01-23 at 09:47

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 16:04 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 02:57:11PM -0800, James Bottomley wrote: > > On Mon, 2017-01-23 at 15:49 -0700, Jason Gunthorpe wrote: > > > On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > > > > On Mon, 2017-01-23 at 09:47

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 02:57:11PM -0800, James Bottomley wrote: > On Mon, 2017-01-23 at 15:49 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > > > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > > > On Mon, Jan 23, 2017 at

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 02:57:11PM -0800, James Bottomley wrote: > On Mon, 2017-01-23 at 15:49 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > > > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > > > On Mon, Jan 23, 2017 at

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 15:49 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > > > From: James Bottomley

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 15:49 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > > > From: James Bottomley > > > >

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > > From: James Bottomley > > > > > > Signed-off-by: James

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 02:28:23PM -0800, James Bottomley wrote: > On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > > From: James Bottomley > > > > > > Signed-off-by: James Bottomley > > > > > > > I really think

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > From: James Bottomley > > > > Signed-off-by: James Bottomley > > > > I really think we

Re: [tpmdd-devel] [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, 2017-01-23 at 09:47 -0700, Jason Gunthorpe wrote: > On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > > From: James Bottomley > > > > Signed-off-by: James Bottomley > > > > I really think we should not use the ugly read/write interface for > any new things. The R/W

Re: [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Signed-off-by: James Bottomley > I really think we should not use the ugly read/write interface for any new things. Still

Re: [PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

On Mon, Jan 23, 2017 at 01:44:32AM +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Signed-off-by: James Bottomley > I really think we should not use the ugly read/write interface for any new things. Still unconvinced we should add a new cdev at this point.. But seeing seesion

[PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

From: James Bottomley Signed-off-by: James Bottomley --- drivers/char/tpm/Makefile | 2 +- drivers/char/tpm/tpm-dev-common.c | 145 ++ drivers/char/tpm/tpm-dev.c|

[PATCH RFC v4 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c

From: James Bottomley Signed-off-by: James Bottomley --- drivers/char/tpm/Makefile | 2 +- drivers/char/tpm/tpm-dev-common.c | 145 ++ drivers/char/tpm/tpm-dev.c| 140 drivers/char/tpm/tpm-dev.h|