Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Joel Fernandes
On Tue, May 1, 2018 at 7:24 AM Steven Rostedt wrote: > On Mon, 30 Apr 2018 18:42:03 -0700 > Joel Fernandes wrote: > > In recent tests with IRQ on/off tracepoints, a large performance > > overhead ~10% is noticed when running hackbench. This is root caused to > > calls to rcu_irq_enter_irqson an

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Joel Fernandes
Missed replying to some comments.. On Tue, May 1, 2018 at 7:24 AM Steven Rostedt wrote: > On Mon, 30 Apr 2018 18:42:03 -0700 > Joel Fernandes wrote: > > In recent tests with IRQ on/off tracepoints, a large performance > > overhead ~10% is noticed when running hackbench. This is root caused to

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Paul E. McKenney
On Tue, May 01, 2018 at 03:23:52PM +, Joel Fernandes wrote: > On Tue, May 1, 2018 at 8:20 AM Paul E. McKenney > wrote: > [...] > > > > > > --- a/kernel/tracepoint.c > > > > > > +++ b/kernel/tracepoint.c > > > > > > @@ -31,6 +31,9 @@ > > > > > > extern struct tracepoint * const __start___trace

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Joel Fernandes
On Tue, May 1, 2018 at 8:20 AM Paul E. McKenney wrote: [...] > > > > > --- a/kernel/tracepoint.c > > > > > +++ b/kernel/tracepoint.c > > > > > @@ -31,6 +31,9 @@ > > > > > extern struct tracepoint * const __start___tracepoints_ptrs[]; > > > > > extern struct tracepoint * const __stop___tracepoint

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Paul E. McKenney
On Tue, May 01, 2018 at 03:16:02PM +, Joel Fernandes wrote: > On Tue, May 1, 2018 at 7:34 AM Paul E. McKenney > wrote: > > > On Tue, May 01, 2018 at 10:24:01AM -0400, Steven Rostedt wrote: > > > On Mon, 30 Apr 2018 18:42:03 -0700 > > > Joel Fernandes wrote: > > > > > > > In recent tests with

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Joel Fernandes
On Tue, May 1, 2018 at 7:34 AM Paul E. McKenney wrote: > On Tue, May 01, 2018 at 10:24:01AM -0400, Steven Rostedt wrote: > > On Mon, 30 Apr 2018 18:42:03 -0700 > > Joel Fernandes wrote: > > > > > In recent tests with IRQ on/off tracepoints, a large performance > > > overhead ~10% is noticed when

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Paul E. McKenney
On Tue, May 01, 2018 at 10:24:01AM -0400, Steven Rostedt wrote: > On Mon, 30 Apr 2018 18:42:03 -0700 > Joel Fernandes wrote: > > > In recent tests with IRQ on/off tracepoints, a large performance > > overhead ~10% is noticed when running hackbench. This is root caused to > > calls to rcu_irq_ente

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Steven Rostedt
On Tue, 01 May 2018 01:56:01 + Joel Fernandes wrote: > This last bit is supposed to be srcu_dereference_notrace. The hunk to use > that is actually in patch 6/6 , sorry about that. I've fixed it in my tree > and it means patches 5/6 and 6/6 need an update. Steve, if you want me to > repost i

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-01 Thread Steven Rostedt
On Mon, 30 Apr 2018 18:42:03 -0700 Joel Fernandes wrote: > In recent tests with IRQ on/off tracepoints, a large performance > overhead ~10% is noticed when running hackbench. This is root caused to > calls to rcu_irq_enter_irqson and rcu_irq_exit_irqson from the > tracepoint code. Following a lon

Re: [PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-04-30 Thread Joel Fernandes
On Mon, Apr 30, 2018 at 6:42 PM Joel Fernandes wrote: > In recent tests with IRQ on/off tracepoints, a large performance > overhead ~10% is noticed when running hackbench. This is root caused to > calls to rcu_irq_enter_irqson and rcu_irq_exit_irqson from the > tracepoint code. Following a long d

[PATCH RFC v5 5/6] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-04-30 Thread Joel Fernandes
In recent tests with IRQ on/off tracepoints, a large performance overhead ~10% is noticed when running hackbench. This is root caused to calls to rcu_irq_enter_irqson and rcu_irq_exit_irqson from the tracepoint code. Following a long discussion on the list [1] about this, we concluded that srcu is