Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:54, Sergei Shtylyov a écrit : > Hello. > > On 4/12/2016 12:22 PM, Nicolas Ferre wrote: > With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by:

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:40, Andrew Lunn a écrit : > On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: >> Le 11/04/2016 04:28, Andrew Lunn a écrit : >>> On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: With the 'phylib' now being aware of the "reset-gpios" PHY node >>>

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Sergei Shtylyov
Hello. On 4/12/2016 12:22 PM, Nicolas Ferre wrote: With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/cadence/macb.c | 17 ---

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Andrew Lunn
On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: > Le 11/04/2016 04:28, Andrew Lunn a écrit : > > On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: > >> With the 'phylib' now being aware of the "reset-gpios" PHY node > >> property, > >> there should be no need to fr

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 11/04/2016 20:51, Andrew Lunn a écrit : > On Mon, Apr 11, 2016 at 09:39:02PM +0300, Sergei Shtylyov wrote: >> Hello. >> >> On 04/11/2016 09:19 PM, Andrew Lunn wrote: >> > The code you are deleting would of ignored the flags in the gpio > property, i.e. active low. Hm, you're

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 11/04/2016 04:28, Andrew Lunn a écrit : > On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: >> With the 'phylib' now being aware of the "reset-gpios" PHY node property, >> there should be no need to frob the PHY reset in this driver anymore... >> >> Signed-off-by: Sergei Shtyl

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-11 Thread Sergei Shtylyov
On 04/11/2016 09:51 PM, Andrew Lunn wrote: The code you are deleting would of ignored the flags in the gpio property, i.e. active low. Hm, you're right -- I forgot about that... :-/ The new code in the previous patch does however take the flags into account. Did you check if there are an

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-11 Thread Andrew Lunn
On Mon, Apr 11, 2016 at 09:39:02PM +0300, Sergei Shtylyov wrote: > Hello. > > On 04/11/2016 09:19 PM, Andrew Lunn wrote: > > >>>The code you are deleting would of ignored the flags in the gpio > >>>property, i.e. active low. > >> > >>Hm, you're right -- I forgot about that... :-/ > >> > >>>Th

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-11 Thread Sergei Shtylyov
Hello. On 04/11/2016 09:19 PM, Andrew Lunn wrote: The code you are deleting would of ignored the flags in the gpio property, i.e. active low. Hm, you're right -- I forgot about that... :-/ The new code in the previous patch does however take the flags into account. Did you check if ther

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-11 Thread Andrew Lunn
> >The code you are deleting would of ignored the flags in the gpio > >property, i.e. active low. > >Hm, you're right -- I forgot about that... :-/ > > >The new code in the previous patch does > >however take the flags into account. Did you check if there are any > >device trees which have fl

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-11 Thread Sergei Shtylyov
Hello. On 04/11/2016 05:28 AM, Andrew Lunn wrote: With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/cadence/macb.c | 17

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-10 Thread Andrew Lunn
On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: > With the 'phylib' now being aware of the "reset-gpios" PHY node property, > there should be no need to frob the PHY reset in this driver anymore... > > Signed-off-by: Sergei Shtylyov > > --- > drivers/net/ethernet/cadence/ma

[PATCH RFT 2/2] macb: kill PHY reset code

2016-04-08 Thread Sergei Shtylyov
With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/cadence/macb.c | 17 - drivers/net/ethernet/cadence/macb.h |1 - 2