On 2017-06-02 23:59, Stephen Boyd wrote:
On 06/01, kgu...@codeaurora.org wrote:
>>@@ -209,23 +210,24 @@ static void pa_read_data(struct
>>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc)
>> * @buf: buffer to write. length must be bc + 1.
>> */
>> static void
>>-pa_write_data(struct
On 2017-06-02 23:59, Stephen Boyd wrote:
On 06/01, kgu...@codeaurora.org wrote:
>>@@ -209,23 +210,24 @@ static void pa_read_data(struct
>>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc)
>> * @buf: buffer to write. length must be bc + 1.
>> */
>> static void
>>-pa_write_data(struct
On 06/01, kgu...@codeaurora.org wrote:
> >>@@ -209,23 +210,24 @@ static void pa_read_data(struct
> >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc)
> >> * @buf: buffer to write. length must be bc + 1.
> >> */
> >> static void
> >>-pa_write_data(struct spmi_pmic_arb_dev *dev, const u8 *buf,
On 06/01, kgu...@codeaurora.org wrote:
> >>@@ -209,23 +210,24 @@ static void pa_read_data(struct
> >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc)
> >> * @buf: buffer to write. length must be bc + 1.
> >> */
> >> static void
> >>-pa_write_data(struct spmi_pmic_arb_dev *dev, const u8 *buf,
Thanks Stephen for reviewing the patches. Responses inline.
Thanks,
Kiran
On 2017-05-31 06:16, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
Usually *_dev best used for structures that embed a struct device in
them. spmi_pmic_arb_dev
Thanks Stephen for reviewing the patches. Responses inline.
Thanks,
Kiran
On 2017-05-31 06:16, Stephen Boyd wrote:
On 05/30, Kiran Gunda wrote:
From: Abhijeet Dharmapurikar
Usually *_dev best used for structures that embed a struct device in
them. spmi_pmic_arb_dev doesn't embed one. It is
On 05/30, Kiran Gunda wrote:
> From: Abhijeet Dharmapurikar
>
> Usually *_dev best used for structures that embed a struct device in
> them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data
> structure. Use an appropriate name for it.
>
> Also there are
On 05/30, Kiran Gunda wrote:
> From: Abhijeet Dharmapurikar
>
> Usually *_dev best used for structures that embed a struct device in
> them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data
> structure. Use an appropriate name for it.
>
> Also there are many places in the driver
From: Abhijeet Dharmapurikar
Usually *_dev best used for structures that embed a struct device in
them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data
structure. Use an appropriate name for it.
Also there are many places in the driver that left shift
From: Abhijeet Dharmapurikar
Usually *_dev best used for structures that embed a struct device in
them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data
structure. Use an appropriate name for it.
Also there are many places in the driver that left shift the bit to
generate a bit
10 matches
Mail list logo