Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-05 Thread kgunda
On 2017-06-02 23:59, Stephen Boyd wrote: On 06/01, kgu...@codeaurora.org wrote: >>@@ -209,23 +210,24 @@ static void pa_read_data(struct >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) >> * @buf: buffer to write. length must be bc + 1. >> */ >> static void >>-pa_write_data(struct

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-05 Thread kgunda
On 2017-06-02 23:59, Stephen Boyd wrote: On 06/01, kgu...@codeaurora.org wrote: >>@@ -209,23 +210,24 @@ static void pa_read_data(struct >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) >> * @buf: buffer to write. length must be bc + 1. >> */ >> static void >>-pa_write_data(struct

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-02 Thread Stephen Boyd
On 06/01, kgu...@codeaurora.org wrote: > >>@@ -209,23 +210,24 @@ static void pa_read_data(struct > >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) > >> * @buf: buffer to write. length must be bc + 1. > >> */ > >> static void > >>-pa_write_data(struct spmi_pmic_arb_dev *dev, const u8 *buf,

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-02 Thread Stephen Boyd
On 06/01, kgu...@codeaurora.org wrote: > >>@@ -209,23 +210,24 @@ static void pa_read_data(struct > >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) > >> * @buf: buffer to write. length must be bc + 1. > >> */ > >> static void > >>-pa_write_data(struct spmi_pmic_arb_dev *dev, const u8 *buf,

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-01 Thread kgunda
Thanks Stephen for reviewing the patches. Responses inline. Thanks, Kiran On 2017-05-31 06:16, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar Usually *_dev best used for structures that embed a struct device in them. spmi_pmic_arb_dev

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-01 Thread kgunda
Thanks Stephen for reviewing the patches. Responses inline. Thanks, Kiran On 2017-05-31 06:16, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar Usually *_dev best used for structures that embed a struct device in them. spmi_pmic_arb_dev doesn't embed one. It is

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-05-30 Thread Stephen Boyd
On 05/30, Kiran Gunda wrote: > From: Abhijeet Dharmapurikar > > Usually *_dev best used for structures that embed a struct device in > them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data > structure. Use an appropriate name for it. > > Also there are

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-05-30 Thread Stephen Boyd
On 05/30, Kiran Gunda wrote: > From: Abhijeet Dharmapurikar > > Usually *_dev best used for structures that embed a struct device in > them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data > structure. Use an appropriate name for it. > > Also there are many places in the driver

[PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-05-30 Thread Kiran Gunda
From: Abhijeet Dharmapurikar Usually *_dev best used for structures that embed a struct device in them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data structure. Use an appropriate name for it. Also there are many places in the driver that left shift

[PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-05-30 Thread Kiran Gunda
From: Abhijeet Dharmapurikar Usually *_dev best used for structures that embed a struct device in them. spmi_pmic_arb_dev doesn't embed one. It is simply a driver data structure. Use an appropriate name for it. Also there are many places in the driver that left shift the bit to generate a bit