RE: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-05-08 Thread Opensource [Steve Twiss]
On 07 May 2014 21:01, Andrew Morton [mailto:a...@linux-foundation.org] wrote: > >So how does this look? > >--- a/drivers/rtc/rtc-da9063.c~rtc-da9063-rtc-driver-fix >+++ a/drivers/rtc/rtc-da9063.c >@@ -82,6 +82,7 @@ static void da9063_tm_to_data(struct rtc > static int da9063_rtc_stop_alarm(struct d

Re: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-05-07 Thread Andrew Morton
On Wed, 7 May 2014 13:22:52 +0100 "Opensource [Steve Twiss]" wrote: > Add the RTC driver for DA9063. A few minor things: > > ... > > +static int da9063_rtc_stop_alarm(struct device *dev) > +{ > + struct da9063_rtc *rtc = dev_get_drvdata(dev); > + return regmap_update_bits(rtc->hw->regm

[RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-05-07 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with next-20140306/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines checked Makefile total: 0 errors, 0 warnings,

[RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-04-25 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with next-20140306/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines checked Makefile total: 0 errors, 0 warnings,

[RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-04-16 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with next-20140306/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines checked Makefile total: 0 errors, 0 warnings,

Re: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-04-11 Thread Alessandro Zummo
On Fri, 11 Apr 2014 11:45:33 + "Opensource [Steve Twiss]" wrote: > Is it possible to merge my RTC patch so it appears in linux-next please? > > You originally Acked it around 1 month ago > https://lkml.org/lkml/2014/3/7/112 Please send me (cc to the list) the whole patchset. thanks! --

RE: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-04-11 Thread Opensource [Steve Twiss]
On 07 March 2014 09:33, Alessandro Zummo wrote, >On Thu, 6 Mar 2014 16:40:02 + >"Opensource [Steve Twiss]" wrote: >> Change History: >> Changes made to this driver since previous RFC V1 >> Comments by Alessandro Zummo >> - http://www.kernelhub.org/?p=2&msg=426327 >> - Use return PTR_ERR(rtc->r

RE: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-26 Thread Opensource [Steve Twiss]
>> I realise that you and Alessandro are very busy (I have not often seen >> Alessandro do any posting in the past fortnight), but a couple of weeks >> ago I sent an RTC patch set with register.h changes ... >> >> >> From: Opensource [Steve Twiss] >> >> >> >> Add the RTC driver for DA9063. >> >>

Re: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-26 Thread Lee Jones
> I realise that you and Alessandro are very busy (I have not often seen > Alessandro do any posting in the past fortnight), but a couple of weeks > ago I sent an RTC patch set with register.h changes ... > > >> From: Opensource [Steve Twiss] > >> > >> Add the RTC driver for DA9063. > > >> The

RE: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-25 Thread Opensource [Steve Twiss]
Hi Lee, I realise that you and Alessandro are very busy (I have not often seen Alessandro do any posting in the past fortnight), but a couple of weeks ago I sent an RTC patch set with register.h changes ... >> From: Opensource [Steve Twiss] >> >> Add the RTC driver for DA9063. >> The original

RE: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-21 Thread Opensource [Steve Twiss]
https://lkml.org/lkml/2014/3/7/112 On 11 March 2014 12:27, Lee Jones wrote: >Subject: Re: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver >> From: Opensource [Steve Twiss] >> >> Add the RTC driver for DA9063. >> >> Signed-off-by: Opensource [Steve Twiss] >

RE: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-11 Thread Opensource [Steve Twiss]
On 11 March 2014 12:27, Lee Jones wrote: >Subject: Re: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver > >> From: Opensource [Steve Twiss] >> >> Add the RTC driver for DA9063. >> >> Signed-off-by: Opensource [Steve Twiss] >> Acked-by: Alessandro Zum

Re: [RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-11 Thread Lee Jones
> From: Opensource [Steve Twiss] > > Add the RTC driver for DA9063. > > Signed-off-by: Opensource [Steve Twiss] > Acked-by: Alessandro Zummo > Acked-by: Lee Jones How could I have Acked a patch that I've never seen? > The original patch is here: > - https://lkml.org/lkml/2014/3/6/346 >

[RESEND] [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-11 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] Acked-by: Alessandro Zummo Acked-by: Lee Jones --- Checks performed with next-20140306/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines checked Makef

RE: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-07 Thread Opensource [Steve Twiss]
>From: Alessandro Zummo [mailto:a.zu...@towertech.it] >Sent: 07 March 2014 09:33 > >On Thu, 6 Mar 2014 16:40:02 + >"Opensource [Steve Twiss]" wrote: > >> Change History: >> >> Changes made to this driver since previous RFC V1 >> Comments by Alessandro Zummo >> - http://www.kernelhub.org/?p=2&

Re: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-07 Thread Alessandro Zummo
On Thu, 6 Mar 2014 16:40:02 + "Opensource [Steve Twiss]" wrote: > Change History: > > Changes made to this driver since previous RFC V1 > Comments by Alessandro Zummo > - http://www.kernelhub.org/?p=2&msg=426327 > - Use return PTR_ERR(rtc->rtc_dev); instead of goto err; return err. > - Reque

[PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-06 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with next-20140306/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines checked Makefile total: 0 errors, 0 warnings,