Re: [PATCH V11 11/11] fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()

2020-06-03 Thread Darrick J. Wong
On Wed, Jun 03, 2020 at 12:10:24PM +0200, Jan Kara wrote: > On Tue 02-06-20 10:23:53, Darrick J. Wong wrote: > > On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote: > > > > -out_unlock: > > > > - xfs_iunlock(ip, XFS_MMAPLOCK_EXCL | XFS_IOLOCK_EXCL); > > > > - return error;

Re: [PATCH V11 11/11] fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()

2020-06-03 Thread Jan Kara
On Tue 02-06-20 10:23:53, Darrick J. Wong wrote: > On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote: > > > -out_unlock: > > > - xfs_iunlock(ip, XFS_MMAPLOCK_EXCL | XFS_IOLOCK_EXCL); > > > - return error; > > > + if ((mp->m_flags & XFS_MOUNT_DAX_ALWAYS) || > > > + (mp->m_flags & X

Re: [PATCH V11 11/11] fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()

2020-06-02 Thread Ira Weiny
On Tue, Jun 02, 2020 at 10:23:53AM -0700, Darrick J. Wong wrote: > On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote: > > On Mon, Apr 27, 2020 at 05:21:42PM -0700, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > ... > > > -out_unlock: > > > - xfs_iunlock(ip, XFS_MMAPLOCK_EX

Re: [PATCH V11 11/11] fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()

2020-06-02 Thread Darrick J. Wong
On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote: > On Mon, Apr 27, 2020 at 05:21:42PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Because of the separation of FS_XFLAG_DAX from S_DAX and the delayed > > setting of S_DAX, data invalidation no longer needs to happe

Re: [PATCH V11 11/11] fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()

2020-04-28 Thread Darrick J. Wong
On Mon, Apr 27, 2020 at 05:21:42PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > Because of the separation of FS_XFLAG_DAX from S_DAX and the delayed > setting of S_DAX, data invalidation no longer needs to happen when > FS_XFLAG_DAX is changed. > > Change xfs_ioctl_setattr_dax_invalid